Remove some pending TODOs (#3746)

dotnet · Dec 13, 2021 · f4bdce3 · f4bdce3
1 parent cae12cd
commit f4bdce3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/src/Controls/src/Core/Platform/AlertManager/AlertManager.Android.cs b/src/Controls/src/Core/Platform/AlertManager/AlertManager.Android.cs
@@ -130,9 +130,7 @@ void OnActionSheetRequested(IView sender, ActionSheetArguments arguments)
 				if (dialog.Window != null)
 				{
 					if (arguments.FlowDirection == FlowDirection.MatchParent && sender is IView view)
-					{
-						// TODO: Update FlowDirection			
-					}
+						dialog.Window.DecorView.UpdateFlowDirection(view);
 					else if (arguments.FlowDirection == FlowDirection.LeftToRight)
 						dialog.Window.DecorView.LayoutDirection = LayoutDirection.Ltr;
 					else if (arguments.FlowDirection == FlowDirection.RightToLeft)
@@ -177,9 +175,7 @@ void OnAlertRequested(IView sender, AlertArguments arguments)
 				if (alert.Window != null)
 				{
 					if (arguments.FlowDirection == FlowDirection.MatchParent && sender is IView view)
-					{
-						// TODO: Update FlowDirection
-					}
+						alert.Window.DecorView.UpdateFlowDirection(view);
 					else if (arguments.FlowDirection == FlowDirection.LeftToRight)
 						alert.Window.DecorView.LayoutDirection = LayoutDirection.Ltr;
 					else if (arguments.FlowDirection == FlowDirection.RightToLeft)

diff --git a/src/Core/src/Platform/Windows/ActivityIndicatorExtensions.cs b/src/Core/src/Platform/Windows/ActivityIndicatorExtensions.cs
@@ -7,8 +7,7 @@ public static class ActivityIndicatorExtensions
 	{
 		public static void UpdateIsRunning(this MauiActivityIndicator mauiActivityIndicator, IActivityIndicator activityIndicator)
 		{
-			// TODO: Use IView Opacity if the ActivityIndicator is running.
-			mauiActivityIndicator.ElementOpacity = activityIndicator.IsRunning ? 1 : 0;
+			mauiActivityIndicator.ElementOpacity = activityIndicator.IsRunning ? activityIndicator.Opacity : 0;
 		}
 		public static void UpdateColor(this MauiActivityIndicator mauiActivityIndicator, IActivityIndicator activityIndicator)
 		{