Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TitleBar] Fix commented out TitleBar style #25248

Closed
PureWeen opened this issue Oct 14, 2024 · 0 comments
Closed

[TitleBar] Fix commented out TitleBar style #25248

PureWeen opened this issue Oct 14, 2024 · 0 comments
Assignees
@Foda
Labels
area-controls-titlebar p/0 Work that we can't release without s/triaged Issue has been reviewed
Milestone
.NET 9.0 GA

Comments

@PureWeen
Copy link
Member

Description

We had to comment these out because of some nuance with our template tests.

We need to make sure to uncomment these before GA

maui/src/Templates/src/templates/maui-mobile/Resources/Styles/Styles.xaml

Line 397 in 8c61eed

<Style TargetType="TitleBar">

@PureWeen PureWeen added this to the .NET 9.0 GA milestone Oct 14, 2024
@dotnet-policy-service dotnet-policy-service bot added the s/triaged Issue has been reviewed label Oct 14, 2024
@PureWeen PureWeen added p/0 Work that we can't release without area-controls-titlebar labels Oct 14, 2024
@PureWeen PureWeen mentioned this issue Oct 14, 2024
Closed
@Foda Foda self-assigned this Oct 14, 2024
@Foda Foda mentioned this issue Oct 18, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress to Done in MAUI SDK Ongoing Oct 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Foda Foda

Labels
area-controls-titlebar p/0 Work that we can't release without s/triaged Issue has been reviewed
Projects
MAUI SDK Ongoing
Status: Done
Milestone
.NET 9.0 GA
Development

No branches or pull requests
2 participants
@Foda @PureWeen