Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Titlebar name API and add templates #25390

Merged
merged 7 commits into from
Oct 20, 2024
Merged

Fix Titlebar name API and add templates #25390

merged 7 commits into from
Oct 20, 2024

Conversation

Foda
Copy link
Member

@Foda Foda commented Oct 18, 2024 •
edited
Loading

Description of Change

  • Rename SubTitle to Subtitle
  • Uncomment out the control templates

Issues Fixed

Fixes #25245 #25248

@Foda Foda requested a review from PureWeen October 18, 2024 20:47
@Foda Foda requested a review from a team as a code owner October 18, 2024 20:47
@Foda Foda requested review from tj-devel709 and removed request for a team October 18, 2024 20:47
@PureWeen PureWeen added this to the .NET 9.0 GA milestone Oct 18, 2024
@PureWeen
Copy link
Member

/rebase

@github-actions github-actions bot force-pushed the foda/Titlebar_Templates branch from 72f9c74 to a14cc2d Compare October 20, 2024 13:23
@PureWeen
Copy link
Member

  • failing test unrelated

@PureWeen PureWeen merged commit 35ec88f into release/9.0.1xx Oct 20, 2024
6 of 7 checks passed
@PureWeen PureWeen deleted the foda/Titlebar_Templates branch October 20, 2024 17:38
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2024
@samhouts samhouts added fixed-in-9.0.0 fixed-in-net8.0-nightly This may be available in a nightly release! labels Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PureWeen PureWeen PureWeen approved these changes

@tj-devel709 tj-devel709 Awaiting requested review from tj-devel709 tj-devel709 is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
fixed-in-9.0.0 fixed-in-net8.0-nightly This may be available in a nightly release!
Projects
MAUI SDK Ongoing
Status: Done
Milestone
.NET 9.0 GA
Development

Successfully merging this pull request may close these issues.
3 participants
@Foda @PureWeen @samhouts