Support Window.Frame on all platforms #10028
Conversation
mattleibow
force-pushed
the
dev/window-fixes
branch
from
b35068b to
90174ca
Compare
mattleibow
changed the title
| @@ -16,7 +16,8 @@ protected override void ConnectHandler(UI.Xaml.Window platformView) | |||
| if (platformView.Content is null) | |||
| platformView.Content = new WindowRootViewContainer(); | |||
|
|
|||
| // update the platform window with the user size | |||
| // update the platform window with the user size/position | |||
| platformView.UpdatePosition(VirtualView); | |||
There was a problem hiding this comment.
The real fix for #9703
|
@rookiejava are you or your team able to confirm that Tizen works as expected? |
| internal static void UpdateX(this Window platformWindow, IWindow window) => | ||
| platformWindow.UpdateUnsupportedCoordinate(window); | ||
|
|
||
| internal static void UpdateY(this Window platformWindow, IWindow window) => | ||
| platformWindow.UpdateUnsupportedCoordinate(window); | ||
|
|
||
| internal static void UpdateWidth(this Window platformWindow, IWindow window) => | ||
| platformWindow.UpdateUnsupportedCoordinate(window); | ||
|
|
||
| internal static void UpdateHeight(this Window platformWindow, IWindow window) => | ||
| platformWindow.UpdateUnsupportedCoordinate(window); | ||
|
|
||
| internal static void UpdateUnsupportedCoordinate(this Window platformWindow, IWindow window) => | ||
| window.FrameChanged(platformWindow.WindowPositionSize.ToDP()); |
There was a problem hiding this comment.
@rookiejava are you or your team able to confirm that Tizen works as expected?
No problems with current tizen implementation at the moment. However, we need more investigation for supporing multi window and window resizing on tizen (with NUI), hopefully it should be supported. If we find a way, I will submit separate PR the actual tizen implementation. 🤙
| { | ||
| internal static partial class ActivityExtensions | ||
| { | ||
| internal static IWindow? GetWindowFromActivity(this Android.App.Activity? activity) |
There was a problem hiding this comment.
Deleting this and moving this code to ContextExtensions.GetWindow which we are already using
There was a problem hiding this comment.
Beautiful. Less code is good code.
| if (e.MessageId == PlatformMethods.MessageIds.WM_SETTINGCHANGE || | ||
| e.MessageId == PlatformMethods.MessageIds.WM_THEMECHANGE) | ||
| { | ||
| var mauiApp = MauiWinUIApplication.Current; |
There was a problem hiding this comment.
Replaced this with
if (IPlatformApplication.Current is IPlatformApplication platformApplication)
| var density = newConfig.DensityDpi / DeviceDisplay.BaseLogicalDpi; | ||
| mauiWindow.DisplayDensityChanged(density); | ||
| } | ||
| MauiApplication.Current?.Services?.InvokeLifecycleEvents<AndroidLifecycle.OnConfigurationChanged>(del => del(this, newConfig)); |
|
|
||
| return null; | ||
| } | ||
| => view?.Context?.GetWindow(); |
There was a problem hiding this comment.
Ha you were already consolidating.
XF: yea it's really hard to get the window
MAUI: here's like 7 extensions you can use with slightly different names :-p
Description
This PR fixes a few more
Windowissues:Tasks
Known Issues
Screenshots