Fix layout and safe area on FlyoutPage #10083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
commented
Sep 13, 2022
| _viewHandlerWrapper.SetVirtualView(element, OnElementChanged, false); | ||
| Presented = ((FlyoutPage)element).IsPresented; |
There was a problem hiding this comment.
This fixes an NRE caused by setting Presented before the _viewHandlerWrapper has been set. Which popped up from the test that's part of this PR
PureWeen
commented
Sep 13, 2022
src/Controls/src/Core/PlatformConfiguration/iOSSpecific/Page.cs
Outdated
Show resolved
Hide resolved
PureWeen
commented
Sep 13, 2022
| @@ -594,29 +594,48 @@ internal static IDisposable OnLoaded(this UIView uiView, Action action) | |||
| } | |||
|
|
|||
| Dictionary<NSString, NSObject> observers = new Dictionary<NSString, NSObject>(); | |||
| ActionDisposable? disposable = new ActionDisposable(() => | |||
| ActionDisposable? disposable = null; | |||
There was a problem hiding this comment.
The modifications here all were necessary to fix FlyoutPage so it would fire Loaded. The Unit Tests use Loaded to know when to proceed with the tests.
jsuarezruiz
added
the
area-layout
PureWeen
force-pushed
the
fix_flyout_safe_area
branch
from
ebdba66 to
91b374e
Compare
hartez
approved these changes
Sep 15, 2022
# Conflicts: # src/Controls/tests/DeviceTests/Stubs/WindowHandlerStub.iOS.cs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Issues Fixed
Fixes #6408