[Core] Changes disposing items in CollectionView #10590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
t/bug
PureWeen
reviewed
Oct 10, 2022
| ve.Handler?.DisconnectHandler(); | ||
|
|
||
| if (ve.Handler is IDisposable veHandlerDisposable) | ||
| veHandlerDisposable.Dispose(); |
There was a problem hiding this comment.
If you remove all the dispose code does that still work?
I don't think we want to start pulling dispose patterns in the code here.
jsuarezruiz
changed the title
|
To help focus and move faster, we're going to have fewer open PRs and focus on the ones we'll be working on in each release. This PR require more work or event think in a better approach and for that reason is not included in the next release so I close it for now. I will reopen it and adapt to changes later. |
Eilon
added
t/perf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Changes (disconnecting and disposing Handlers) disposing items in Windows CollectionView.
Testing with a CollectionView having 1000 items scrolling up and down. This is the current behavior:
After the changes:
The memory consumption and the references count is much lower with the changes.
Forcing a GC.Collect doing scroll:
We can see how memory is constantly collected and in this case the memory does not increase.
Issues Fixed
Fixes #10560