Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_itemsSource may be null in CarouselViewLoopManager #11000

Merged
merged 4 commits into from
Nov 28, 2022
Merged

_itemsSource may be null in CarouselViewLoopManager #11000

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5fd121c
_itemsSource may be null
BioTurboNick Oct 30, 2022
df50f1d
fix dropped semicolon
BioTurboNick Oct 30, 2022
28c8825
Merge branch 'main' into pr/11000
Redth Nov 22, 2022
a283c1a
Merge branch 'dotnet:main' into patch-1
BioTurboNick Nov 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/Controls/src/Core/Handlers/Items/Android/CarouselViewLoopManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ public void CenterIfNeeded(RecyclerView recyclerView, bool isHorizontal)
{
if (!(recyclerView.GetLayoutManager() is LinearLayoutManager linearLayoutManager))
return;
if (_itemsSource is null)
return;

var itemSourceCount = _itemsSource.Count;

Expand Down Expand Up @@ -43,7 +45,9 @@ public int GetGoToIndex(RecyclerView recyclerView, int carouselPosition, int new
{
if (!(recyclerView.GetLayoutManager() is LinearLayoutManager linearLayoutManager))
return -1;

if (_itemsSource is null)
return -1;

var currentCarouselPosition = carouselPosition;
var itemSourceCount = _itemsSource.Count;

Expand Down