Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Button.ImageSource to be updated on Android, iOS and macOS #11008

Conversation

espenrl
Copy link
Contributor

@espenrl espenrl commented Oct 31, 2022

In the current implementation Button.ImageSource only reacts to updates on Windows. This PR add support for Android, iOS and macOS.

Tizen support

Tizen should probably also be supported. But given that I don't have a setup to test Tizen I have not implemented it.

A note on Image and ImageButton

Image and ImageButton is verified to NOT have the problem.

@ghost ghost added the community ✨ Community Contribution label Oct 31, 2022
@ghost
Copy link

ghost commented Oct 31, 2022

Hey there @espenrl! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@Eilon Eilon added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Oct 31, 2022
@rmarinho
Copy link
Member

rmarinho commented Nov 2, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@espenrl
Copy link
Contributor Author

espenrl commented Nov 23, 2022

It may have been resolved by #11146 I´m not sure if it´s the same issue or not.

@jfversluis jfversluis self-assigned this Jan 30, 2023
@jfversluis
Copy link
Member

@espenrl have you verified if this is indeed still an issue or that this has been fixed by more recent releases?

@espenrl
Copy link
Contributor Author

espenrl commented Jan 30, 2023

This is fixed in .NET 7 SR2

@espenrl espenrl closed this Jan 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
@Eilon Eilon added area-controls-button Button, ImageButton and removed legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants