Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add await for color check to avoid crash and fix DispatcherTest #11022

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Add await for color check to avoid crash and fix DispatcherTest #11022

merged 1 commit into from
Nov 1, 2022

Conversation

PureWeen
Copy link
Member

Description of Change

  • This is a simplified version of this PR so that we can remove the crashers first. The ValidateHasColor call is wrong everywhere which is leading it to cause false positives. If you correctly await the ValidateHasColor check then it correctly fails.
  • Label test validating color is currently missing an await. This was causing the test to complete, and the AppBuilder to dispose before the view under test was removed from the window. This was leading to latent android events firing from layout changed code that would then try to use the disposed AppBuilder
  • Reworked DispatcherTest slightly so it runs better when part of a full test run

@PureWeen PureWeen enabled auto-merge (squash) October 31, 2022 22:22
@PureWeen PureWeen merged commit 34c5e9f into main Nov 1, 2022
@PureWeen PureWeen deleted the fix_missing_await_less_rabbits branch November 1, 2022 22:56
rmarinho pushed a commit that referenced this pull request Nov 2, 2022
@PureWeen @rmarinho
Add await for color check to avoid crash (#11022)
f32cbd5
rmarinho added a commit that referenced this pull request Nov 3, 2022
@rmarinho @PureWeen
@Redth @cadsit
Cherry pick net7 (#11056)
ad91996 
* Fix Author Name (#11015)

* Add await for color check to avoid crash (#11022)

* Remove unused reference (#11048)

* Invoke provisionator with AUTH_TOKEN_GITHUB_COM set (#11041)

# Conflicts:
#	eng/pipelines/common/provision.yml

Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
Co-authored-by: Jonathan Dick <jondick@gmail.com>
Co-authored-by: Connor Adsit <connor.adsit@gmail.com>
@samhouts samhouts added the area-testing Unit tests, device tests label Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hartez hartez hartez approved these changes

Assignees
No one assigned
Labels
area-testing Unit tests, device tests fixed-in-8.0.0-preview.1.7762 Look for this fix in 8.0.0-preview.1.7762!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PureWeen @hartez @samhouts