Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tizen] Add Label TextType #11103

Closed
wants to merge 3 commits into from

Conversation

JoonghyunCho
Copy link
Contributor

Description of Change

This PR adds

  • handling Label.TextType features including FormattedText and Html type of text.
  • updating Font loading process to include MauiFont as a custom font path.

At this point, Tizen.UIExtensions package which actually process the span creates a new line for each spans. This will be fixed in Tizen.UIExtensions package.

@ghost ghost added the community ✨ Community Contribution label Nov 4, 2022
@ghost
Copy link

ghost commented Nov 4, 2022

Hey there @JoonghyunCho! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@rmarinho
Copy link
Member

rmarinho commented Nov 4, 2022

/azp run

@rmarinho
Copy link
Member

rmarinho commented Nov 4, 2022

/backport to net7.0

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Started backporting to net7.0: https://github.com/dotnet/maui/actions/runs/3393384354

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

@rmarinho backporting to net7.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: [Tizen] Add handing Label.TextType
Using index info to reconstruct a base tree...
M	src/Controls/src/Core/Platform/Tizen/Extensions/TextExtensions.cs
M	src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Shipped.txt
M	src/Core/src/Fonts/FontManager.Tizen.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Core/src/Fonts/FontManager.Tizen.cs
Auto-merging src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Shipped.txt
CONFLICT (content): Merge conflict in src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Shipped.txt
Auto-merging src/Controls/src/Core/Platform/Tizen/Extensions/TextExtensions.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 [Tizen] Add handing Label.TextType
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

@rmarinho an error occurred while backporting to net7.0, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

@Eilon Eilon added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Nov 4, 2022
@rookiejava
Copy link
Contributor

rookiejava commented Nov 7, 2022

@rmarinho In addition to this PR, I think there are a few more PRs that need backporting to net7.0. (e.g., #11027, #10201,...)
I'll backport manually all at once soon.

@mattleibow
Copy link
Member

/backport to main

@github-actions
Copy link
Contributor

Started backporting to main: https://github.com/dotnet/maui/actions/runs/3464806036

@github-actions
Copy link
Contributor

@mattleibow an error occurred while backporting to main, please check the run log for details!

Error: @mattleibow is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=mattleibow

@mattleibow
Copy link
Member

/backport to main

@github-actions
Copy link
Contributor

Started backporting to main: https://github.com/dotnet/maui/actions/runs/3464827427

@github-actions
Copy link
Contributor

@mattleibow backporting to main failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: [Tizen] Add handing Label.TextType
Using index info to reconstruct a base tree...
M	src/Controls/src/Core/Platform/Tizen/Extensions/TextExtensions.cs
M	src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Shipped.txt
M	src/Core/src/Fonts/FontManager.Tizen.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Core/src/Fonts/FontManager.Tizen.cs
Auto-merging src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Shipped.txt
CONFLICT (content): Merge conflict in src/Controls/src/Core/PublicAPI/net-tizen/PublicAPI.Shipped.txt
Auto-merging src/Controls/src/Core/Platform/Tizen/Extensions/TextExtensions.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 [Tizen] Add handing Label.TextType
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

@github-actions
Copy link
Contributor

@mattleibow an error occurred while backporting to main, please check the run log for details!

Error: git am failed, most likely due to a merge conflict.

@JoonghyunCho JoonghyunCho changed the base branch from net6.0 to main November 15, 2022 18:49
@JoonghyunCho
Copy link
Contributor Author

remake the PR #11389 against main branch

@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2023
@Eilon Eilon added area-controls-label Label, Span and removed legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-label Label, Span community ✨ Community Contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants