[RadioButton] Fix Issue with BorderWidth, Incorrect spacing in Default Control Template. #13407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngs to fix border width not being applied.
…ioButton. Added padding to underlying grid to prevent clipping of RadioButton.
|
Thank you for your pull request. We are auto-formating your source code to follow our code guidelines. |
jsuarezruiz
added
area-controls-radiobutton
…rame, as well as test for three additional RadioButton properties.
|
Thank you for your pull request. We are auto-formating your source code to follow our code guidelines. |
…eated new test for BorderColorProperty, BorderWidthProperty, and CornerRadiusProperty
mattleibow
approved these changes
Feb 28, 2023
We looked at doing this when we went over to MAUI and determined that it didn't add enough value given that it would be a breaking change. |
Eilon
removed
the
legacy-area-controls
samhouts
added
the
fixed-in-8.0.0-preview.3.8149
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This adapts a previously submitted PR that was closed before it was reviewed: #8292 The underlying Frame was changed to a Border to support BorderWidth attribute not working.
An addition of column spacing to the underlying grid fixes the ellipse being too close to the content text, and additional padding of the grid prevents it from clipping.
Question that arose:
According to docs for RadioButton, CornerRadius is set to be an integer: CornerRadius however, Corner Radius use double values: Corner Radius Constructor. Should I change the API to reflect this?
Issues Fixed
Fixes #8291