Add Idiom to MauiContext #1341
Closed
Add Idiom to MauiContext #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmrAlSayed0
reviewed
Jun 17, 2021
| public IMauiHandlersServiceProvider Handlers => | ||
| _mauiHandlersServiceProvider ?? throw new InvalidOperationException($"No service provider was specified during construction."); | ||
|
|
||
| public TargetIdiom Idiom |
There was a problem hiding this comment.
Does this really need to be reimplemented? Xamarin.Essentials already has an implementation for it. https://docs.microsoft.com/en-us/xamarin/essentials/device-information?tabs=ios
There was a problem hiding this comment.
There was a problem hiding this comment.
You are right, must use Essentials as specified in Spec #1305
|
After a team meeting, we are going to do this in a different way. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Add
Idiomto MauiContextImplements #1305
PR Checklist
Does this PR touch anything that might affect accessibility?