-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create development path without compatibility projects #13660
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
commented
Mar 2, 2023
src/Controls/tests/Core.UnitTests/Controls.Core.UnitTests.csproj
Outdated
Show resolved
Hide resolved
mandel-macaque
approved these changes
Mar 3, 2023
Eilon
added
the
area-infrastructure
CI, Maestro / Coherency, upstream dependencies/versions
label
Mar 6, 2023
PureWeen
force-pushed
the
remove_compatibility_project
branch
from
March 9, 2023 17:54
a5cadaf
to
477bdf3
Compare
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
mattleibow
reviewed
Mar 13, 2023
src/Controls/tests/Core.UnitTests/Controls.Core.UnitTests.csproj
Outdated
Show resolved
Hide resolved
src/Controls/tests/Core.UnitTests/Controls.Core.UnitTests.csproj
Outdated
Show resolved
Hide resolved
PureWeen
force-pushed
the
remove_compatibility_project
branch
from
March 14, 2023 12:57
591b7a5
to
8f3313c
Compare
mattleibow
reviewed
Mar 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
src/Controls/tests/Xaml.UnitTests/ResourceDictionaryWithSource.xaml
Outdated
Show resolved
Hide resolved
src/Controls/tests/Xaml.UnitTests/ResourceDictionaryWithSource.xaml.cs
Outdated
Show resolved
Hide resolved
Eilon
approved these changes
Mar 14, 2023
mattleibow
approved these changes
Mar 14, 2023
mattleibow
approved these changes
Mar 15, 2023
samhouts
added
the
fixed-in-8.0.0-preview.3.8149
Look for this fix in 8.0.0-preview.3.8149!
label
Aug 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-infrastructure
CI, Maestro / Coherency, upstream dependencies/versions
fixed-in-8.0.0-preview.3.8149
Look for this fix in 8.0.0-preview.3.8149!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The entire compatibility folder is currently not used for any active MAUI development. It currently just slows down the solution load and creates more cognitive load for users.
Microsoft.Maui-dev.sln
. The main reason for doing this is to conditionally include the compatibility project references inside any of our sample's projects. This also lets you loadMicrosoft.Maui.sln
as if theCompatibility
project was still present which should also keep CI consistent. I would have done this with a solution filter but it's currently not possible to know if you are running a solution filter or not.Controls.UnitTests
that dependend onCompatibility
.Other thoughts
Microsoft.Maui.sln
toMicrosoft.Maui-full.sln
and this is what we build on CI. TheMicrosoft.Maui-dev.sln
in this PR becomesMicrosoft.Maui.sln
Compatibility
bits into its ownMicrosoft.Maui.Compatibility.sln
and then we just make sure to build this on CI to validate everything compiles.Work to do