Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create development path without compatibility projects #13660

Merged
merged 3 commits into from
Mar 15, 2023

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Mar 2, 2023

Description of Change

The entire compatibility folder is currently not used for any active MAUI development. It currently just slows down the solution load and creates more cognitive load for users.

  • I created a new solution Microsoft.Maui-dev.sln. The main reason for doing this is to conditionally include the compatibility project references inside any of our sample's projects. This also lets you load Microsoft.Maui.sln as if the Compatibility project was still present which should also keep CI consistent. I would have done this with a solution filter but it's currently not possible to know if you are running a solution filter or not.
  • Created a new compatibility unit test project for the unit tests we had in Controls.UnitTests that dependend on Compatibility.

Other thoughts

  • Rename Microsoft.Maui.sln to Microsoft.Maui-full.sln and this is what we build on CI. The Microsoft.Maui-dev.sln in this PR becomes Microsoft.Maui.sln
  • Move all of the Compatibility bits into its own Microsoft.Maui.Compatibility.sln and then we just make sure to build this on CI to validate everything compiles.

Work to do

  • once this approach is approved, I'll update the applicable docs as well

@Eilon Eilon added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Mar 6, 2023
@PureWeen PureWeen force-pushed the remove_compatibility_project branch from a5cadaf to 477bdf3 Compare March 9, 2023 17:54
@PureWeen PureWeen marked this pull request as ready for review March 9, 2023 17:55
@PureWeen PureWeen requested a review from a team as a code owner March 9, 2023 17:55
@PureWeen PureWeen requested a review from mattleibow March 13, 2023 15:51
@PureWeen
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@PureWeen PureWeen force-pushed the remove_compatibility_project branch from 591b7a5 to 8f3313c Compare March 14, 2023 12:57
@PureWeen PureWeen requested a review from mattleibow March 14, 2023 12:57
Copy link
Member

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

@PureWeen PureWeen requested a review from mattleibow March 14, 2023 15:51
@mattleibow mattleibow enabled auto-merge (squash) March 15, 2023 09:33
@mattleibow mattleibow merged commit 474d332 into main Mar 15, 2023
@mattleibow mattleibow deleted the remove_compatibility_project branch March 15, 2023 09:33
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants