Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C] Properly set SelectedItem and Index #13740

Merged
merged 1 commit into from
Mar 15, 2023
Merged

[C] Properly set SelectedItem and Index #13740

merged 1 commit into from
Mar 15, 2023

Conversation

StephaneDelcroix
Copy link
Contributor

Description of Change

Avoid clearing bindings, by setting the BP instead of the property

Issues Fixed

fixes #6571

Avoid clearing bindings, by setting the BP instead of the property

fixes #6571
@rmarinho
Copy link
Member

rmarinho commented Mar 8, 2023

Can we add a unit test?

@jsuarezruiz jsuarezruiz added area-xaml XAML, CSS, Triggers, Behaviors area-controls-picker Picker labels Mar 8, 2023
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Mar 8, 2023
@jsuarezruiz
Copy link
Contributor

This could also fix other issues like #7138 or #9150

Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked with @StephaneDelcroix and seems it's not that easy to test this.

@rmarinho rmarinho merged commit 83fea9c into main Mar 15, 2023
@rmarinho rmarinho deleted the fix_gh6571 branch March 15, 2023 18:41
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-picker Picker area-xaml XAML, CSS, Triggers, Behaviors fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET MAUI MVVM OneWay bindings issues
6 participants