Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vs-workload] Use variable to control VSMAN name #13873

Merged
merged 1 commit into from
Mar 14, 2023
Merged

[vs-workload] Use variable to control VSMAN name #13873

merged 1 commit into from
Mar 14, 2023

Conversation

pjcollins
Copy link
Member

In .NET 8 we will want our VSMAN files to be versioned with a .net8.0 suffix.

@pjcollins
[vs-workload] Use variable to control VSMAN name
02fb1be 
In .NET 8 we will want our VSMAN files to be versioned with a `.net8.0`
suffix.
@jonathanpeppers
Copy link
Member

Will we want to backport this to release/8.0.1xx-preview2?

@mandel-macaque
Copy link
Member

Will we want to backport this to release/8.0.1xx-preview2?

yes, at least to make the unified pipeline work easier.

@pjcollins
Copy link
Member Author

Will we want to backport this to release/8.0.1xx-preview2?

Yeah we'll need this on all 8.0 related branches, including net8.0.

@pjcollins
Copy link
Member Author

This looks like it worked fine for the net7.0 based main, generating a file with:

    <TargetName>Microsoft.NET.Sdk.Maui.Workload.net7.0</TargetName>

Is there a bot I should use to backport or what is the usual process for that?

@Eilon Eilon added the area-setup Installation, setup, requirements, maui-check, workloads, platform support label Mar 13, 2023
@rmarinho
Copy link
Member

@pjcollins yeah you can use /backport to branch name , it will trigger the bot

@pjcollins pjcollins enabled auto-merge (squash) March 13, 2023 16:47
@mattleibow
Copy link
Member

/backport to release/8.0.1xx-preview1

@github-actions
Copy link
Contributor

Started backporting to release/8.0.1xx-preview1: https://github.com/dotnet/maui/actions/runs/4407640663

@github-actions github-actions bot mentioned this pull request Mar 13, 2023
Merged
@mattleibow
Copy link
Member

Starting the backport so the build can get going.

@pjcollins
Copy link
Member Author

@mattleibow @rmarinho can we start merging without waiting for all the test stages? I checked the build output from this PR and it looks good, and these changes won't have any impact on tests.

@rmarinho
Copy link
Member

@pjcollins I think we can't since this setting is on GitHub and we can't make it ignore in a particular branch

@pjcollins pjcollins disabled auto-merge March 13, 2023 17:20
@rmarinho
Copy link
Member

/backport to release/8.0.1xx-preview2

@github-actions
Copy link
Contributor

Started backporting to release/8.0.1xx-preview2: https://github.com/dotnet/maui/actions/runs/4407891379

@github-actions github-actions bot mentioned this pull request Mar 13, 2023
Merged
@pjcollins
Copy link
Member Author

/backport to net8.0

@github-actions
Copy link
Contributor

Started backporting to net8.0: https://github.com/dotnet/maui/actions/runs/4409018936

@github-actions
Copy link
Contributor

@pjcollins an error occurred while backporting to net8.0, please check the run log for details!

Error: @pjcollins is not a repo collaborator, backporting is not allowed. If you're a collaborator please make sure your dotnet team membership visibility is set to Public on https://github.com/orgs/dotnet/people?query=pjcollins

@pjcollins
Copy link
Member Author

/backport to net8.0

@github-actions
Copy link
Contributor

Started backporting to net8.0: https://github.com/dotnet/maui/actions/runs/4409220521

@github-actions github-actions bot mentioned this pull request Mar 13, 2023
Merged
@rmarinho rmarinho merged commit d87abe8 into main Mar 14, 2023
@rmarinho rmarinho deleted the dev/pjc/net8vsman branch March 14, 2023 11:33
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@rmarinho rmarinho rmarinho approved these changes

@mattleibow mattleibow mattleibow approved these changes

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

Assignees
No one assigned
Labels
area-setup Installation, setup, requirements, maui-check, workloads, platform support fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pjcollins @jonathanpeppers @mandel-macaque @rmarinho @mattleibow @Eilon @samhouts