-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalidate shapes changing any property inside the brushes (Fill, Stroke) #13905
Conversation
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines. |
@jonathanpeppers Could you review it again?. Thanks! |
stroke.Color = Colors.Green; | ||
Assert.True(fired, "PropertyChanged did not fire!"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I found an issue in this pattern, if you change this to:
stroke.Color = Colors.Green; | |
Assert.True(fired, "PropertyChanged did not fire!"); | |
await Task.Yield(); | |
GC.Collect(); | |
GC.WaitForPendingFinalizers(); | |
stroke.Color = Colors.Green; | |
Assert.True(fired, "PropertyChanged did not fire!"); |
Does it fail? I found saving some delegates in a member variable fixes it, but looking how we can do it in a nicer way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow what I did here to get the above test to pass: #13997
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description of Change
Invalidate shapes changing any property inside the brushes (Fill, Stroke).
Issues Fixed
Fixes #13891