-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure that Grid is treating star rows/columns as Auto when unconstrained #13999
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -373,14 +373,17 @@ void KnownMeasurePass() | |
{ | ||
var cell = _cells[n]; | ||
|
||
bool treatCellHeightAsAuto = TreatCellHeightAsAuto(cell); | ||
bool treatCellWidthAsAuto = TreatCellWidthAsAuto(cell); | ||
|
||
if (double.IsNaN(cell.MeasureHeight) || double.IsNaN(cell.MeasureWidth)) | ||
{ | ||
// We still have some unknown measure constraints (* rows/columns that need to have | ||
// the Auto measurements settled before we can measure them). So mark this cell for the | ||
// second pass, once we know the constraints. | ||
cell.NeedsSecondPass = true; | ||
|
||
if (!cell.IsColumnSpanAuto && !cell.IsRowSpanAuto) | ||
if (!(treatCellHeightAsAuto || treatCellWidthAsAuto)) | ||
{ | ||
// If neither span of this cell includes _any_ Auto values, then there's no reason | ||
// to measure it at all during this pass; we can skip it for now | ||
|
@@ -393,7 +396,7 @@ void KnownMeasurePass() | |
|
||
var measure = MeasureCell(cell, measureWidth, measureHeight); | ||
|
||
if (cell.IsColumnSpanAuto) | ||
if (treatCellWidthAsAuto) | ||
{ | ||
if (cell.ColumnSpan == 1) | ||
{ | ||
|
@@ -405,7 +408,7 @@ void KnownMeasurePass() | |
} | ||
} | ||
|
||
if (cell.IsRowSpanAuto) | ||
if (treatCellHeightAsAuto) | ||
{ | ||
if (cell.RowSpan == 1) | ||
{ | ||
|
@@ -971,15 +974,10 @@ void DetermineCellMeasureWidth(Cell cell) | |
{ | ||
UpdateKnownMeasureWidth(cell); | ||
} | ||
else if (cell.IsColumnSpanAuto) | ||
else if (TreatCellWidthAsAuto(cell)) | ||
{ | ||
cell.MeasureWidth = double.PositiveInfinity; | ||
} | ||
else if (cell.IsColumnSpanStar && double.IsInfinity(_gridWidthConstraint)) | ||
{ | ||
// Because the Grid isn't horizontally constrained, we treat * columns as Auto | ||
cell.MeasureWidth = double.PositiveInfinity; | ||
} | ||
|
||
// For all other situations, we'll have to wait until we've measured the Auto columns | ||
} | ||
|
@@ -990,17 +988,44 @@ void DetermineCellMeasureHeight(Cell cell) | |
{ | ||
UpdateKnownMeasureHeight(cell); | ||
} | ||
else if (cell.IsRowSpanAuto) | ||
else if (TreatCellHeightAsAuto(cell)) | ||
{ | ||
cell.MeasureHeight = double.PositiveInfinity; | ||
} | ||
else if (cell.IsRowSpanStar && double.IsInfinity(_gridHeightConstraint)) | ||
|
||
// For all other situations, we'll have to wait until we've measured the Auto rows | ||
} | ||
|
||
bool TreatCellWidthAsAuto(Cell cell) | ||
{ | ||
if (cell.IsColumnSpanAuto) | ||
{ | ||
// Because the Grid isn't vertically constrained, we treat * rows as Auto | ||
cell.MeasureHeight = double.PositiveInfinity; | ||
return true; | ||
} | ||
|
||
// For all other situations, we'll have to wait until we've measured the Auto rows | ||
if (double.IsInfinity(_gridWidthConstraint) && cell.IsColumnSpanStar) | ||
{ | ||
// Because the Grid isn't horizontally constrained, we treat * columns as Auto | ||
return true; | ||
} | ||
|
||
return false; | ||
} | ||
|
||
bool TreatCellHeightAsAuto(Cell cell) | ||
{ | ||
if (cell.IsRowSpanAuto) | ||
{ | ||
return true; | ||
} | ||
|
||
if (double.IsInfinity(_gridHeightConstraint) && cell.IsRowSpanStar) | ||
{ | ||
// Because the Grid isn't vertically constrained, we treat * rows as Auto | ||
return true; | ||
} | ||
|
||
return false; | ||
Comment on lines
+1022
to
+1028
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Samer comment. |
||
} | ||
} | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just return? no need for the if