Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a layout for MauiButton on Windows which supports LineBreakMode #14036

Merged
merged 1 commit into from
Mar 21, 2023

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Mar 17, 2023

Description of Change

Proposing this as an alternative to #10759.

Use a Grid for the content of the MauiButton rather than a StackPanel so we can support LineBreakMode in the button's TextBlock.

Issues Fixed

Fixes #9277

@hartez hartez requested review from PureWeen and jsuarezruiz March 17, 2023 22:03
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Mar 20, 2023
Copy link
Contributor

@jsuarezruiz jsuarezruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

button-linebreakmode

@hartez hartez merged commit 9aa30fc into main Mar 21, 2023
@hartez hartez deleted the fix-9277 branch March 21, 2023 18:12
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-button Button, ImageButton fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! platform/windows 🪟
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Windows] LineBreakMode doesn't work on Button
5 participants