Fix edge case with Grids, *s, and unconstrained layouts #14114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In a layout like this one:
The Grid is taking the natural stacked size of the rows and trying to distribute the heights evenly (because of the * values), even though the
VerticalOptions="Fill"
shouldn't have any meaning in a vertically unconstrained layout. This ends up creating some weird layout results. The Grid should be ignoring the "Fill" in this situation and just leaving the rows at their originally measured heights. (A similar issue is present for columns in horizontally unconstrained layouts.)This PR fixes the issue so the Grid behaves.