Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move maybe null when attribute back to core #14269

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Move maybe null when attribute back to core #14269

merged 1 commit into from
Mar 29, 2023

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Mar 29, 2023 •
edited
Loading

Description of Change

Move CodeAnalysis Attributes back to core so we can make use of them inside our core and controls code.

#12227 (comment)

jonathanpeppers
jonathanpeppers approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If everything builds, this should work fine.

The various nullable attributes work by the name matching, so it doesn't matter what assembly they come from.

@PureWeen PureWeen enabled auto-merge (squash) March 29, 2023 16:20
@PureWeen PureWeen merged commit e946b47 into main Mar 29, 2023
@PureWeen PureWeen deleted the move_maybe_null_when_attribute_back_to_core branch March 29, 2023 18:36
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2023
@samhouts samhouts added the fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

Assignees
No one assigned
Labels
fixed-in-8.0.0-preview.3.8149 Look for this fix in 8.0.0-preview.3.8149! t/housekeeping ♻︎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@PureWeen @jonathanpeppers @jsuarezruiz @samhouts