-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support reading fonts from files #14783
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file added
BIN
+2.05 MB
src/Core/tests/DeviceTests/Platforms/Windows/Assets/Fonts/insubfolder.ttf
Binary file not shown.
40 changes: 40 additions & 0 deletions
40
src/Core/tests/DeviceTests/Services/FontManagerTests.Windows.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
using System; | ||
using System.Threading.Tasks; | ||
using Xunit; | ||
|
||
namespace Microsoft.Maui.DeviceTests; | ||
|
||
public partial class FontManagerTests : TestBase | ||
{ | ||
[Theory] | ||
[InlineData("dokdo_regular", "ms-appx:///dokdo_regular.ttf#Dokdo")] | ||
[InlineData("dokdo_regular.ttf", "ms-appx:///dokdo_regular.ttf#Dokdo")] | ||
[InlineData("dokdo_regular#dokdo", "ms-appx:///dokdo_regular.ttf#Dokdo")] | ||
[InlineData("dokdo_regular.ttf#dokdo", "ms-appx:///dokdo_regular.ttf#Dokdo")] | ||
[InlineData("myalias", "ms-appx:///dokdo_regular.ttf#Dokdo")] | ||
public Task CanLoadFonts(string fontName, string actualFontFamily) => | ||
InvokeOnMainThreadAsync(() => | ||
{ | ||
var registrar = new FontRegistrar(fontLoader: null); | ||
registrar.Register("dokdo_regular.ttf", "myalias"); | ||
var manager = new FontManager(registrar); | ||
|
||
var actual = manager.GetFontFamily(Font.OfSize(fontName, 12, FontWeight.Regular)); | ||
|
||
Assert.Equal(actualFontFamily, actual.Source); | ||
}); | ||
|
||
// TODO: this is not going to work in unpackaged | ||
[Fact] | ||
public Task CanLoadEmbeddedFont() => | ||
InvokeOnMainThreadAsync(() => | ||
{ | ||
var registrar = new FontRegistrar(new EmbeddedFontLoader()); | ||
registrar.Register("dokdo_regular.ttf", "myalias", GetType().Assembly); | ||
var manager = new FontManager(registrar); | ||
|
||
var actual = manager.GetFontFamily(Font.OfSize("myalias", 12, FontWeight.Regular)); | ||
|
||
Assert.Equal("ms-appdata:///local/fonts/dokdo_regular.ttf#Dokdo", actual.Source); | ||
}); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
#nullable enable | ||
using System; | ||
using System.Diagnostics.CodeAnalysis; | ||
using System.IO; | ||
using Microsoft.Maui.ApplicationModel; | ||
using Package = Windows.ApplicationModel.Package; | ||
|
||
namespace Microsoft.Maui.Storage | ||
{ | ||
static partial class FileSystemUtils | ||
{ | ||
public static bool AppPackageFileExists(string filename) | ||
{ | ||
var file = PlatformGetFullAppPackageFilePath(filename); | ||
return File.Exists(file); | ||
} | ||
|
||
public static string PlatformGetFullAppPackageFilePath(string filename) | ||
{ | ||
if (filename is null) | ||
throw new ArgumentNullException(nameof(filename)); | ||
|
||
filename = NormalizePath(filename); | ||
|
||
string root; | ||
if (AppInfoUtils.IsPackagedApp) | ||
root = Package.Current.InstalledLocation.Path; | ||
else | ||
root = AppContext.BaseDirectory; | ||
|
||
return Path.Combine(root, filename); | ||
} | ||
|
||
public static bool TryGetAppPackageFileUri(string filename, [NotNullWhen(true)] out string? uri) | ||
{ | ||
var path = PlatformGetFullAppPackageFilePath(filename); | ||
|
||
if (File.Exists(path)) | ||
{ | ||
if (AppInfoUtils.IsPackagedApp) | ||
uri = $"ms-appx:///{filename.Replace('\\', '/')}"; | ||
else | ||
uri = $"file:///{path.Replace('\\', '/')}"; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This can be handled by the bcl in a much nicer way: var uri = new Uri("c:\\foo");
var converted = uri.AbsoluteUri; Example:
No need to worry about corner cases etc |
||
|
||
return true; | ||
} | ||
|
||
uri = null; | ||
return false; | ||
} | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the real change for unpackaged, we determine the full path to the font and use that. Packaged still uses the same
ms-appx://
. Technically the full path also works in packaged, but no need to change what works.