Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm that the tests are broken #1511

Closed
wants to merge 3 commits into from
Closed

Conversation

mattleibow
Copy link
Member

Description of Change

Implements #

Additions made

  • Adds

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

# Conflicts:
#	Microsoft.Maui-net6.sln
#	src/Controls/tests/Core.UnitTests/Controls.Core.UnitTests-net6.csproj
mattleibow added a commit that referenced this pull request Jul 1, 2021
PureWeen pushed a commit that referenced this pull request Jul 1, 2021
* Initial window handler

* Get things building

* things

* maybe this

* that

* Improve that

* A WIP WIP

* Dispose old things

* Things

* Add WindowHandler for Windows

* remove that since we get a new handler each time

* ws

* Merge the changed property mapper

* that

* Register the resources in the builder

* undo

* Use a better Window lifecycle event

* The OfT bust interface the base

* tests

* no need for SetWindow

* Fix things

* use a BP Page

* Correctly register Windows resource dictionaries

* Use handlers...

View -> Content for consistency

* Handler-ize

* iOS things

* undo tests

* tests

* Support changing the Window.Page

* Disable some tests

#1511

* IsApplicationOrWindowOrNull

* Always fire this

* nullable not needed

* Make IWindowHandler internal for now
@mattleibow mattleibow marked this pull request as draft September 28, 2021 09:09
@Redth Redth closed this Jan 27, 2022
@mattleibow mattleibow deleted the dev/net6-controls-tests branch April 4, 2022 16:50
@samhouts samhouts added the area-testing Unit tests, device tests label Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing Unit tests, device tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants