Fix issues with ScrollView on ios that does not correctly resize when…

[jadenrogers]

Description of Change

Fixes ScrollView on ios not being correctly sized when changes occur within the ScrollView content.

Issues Fixed

fixes #15374
fixes #14624
fixes #15288
fixes #15283
fixes #14795

[ghost]

Hey there @jadenrogers! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

[jadenrogers]

@dotnet-policy-service agree

[jadenrogers]

@PureWeen

[jadenrogers]

Hi @hartez This PR is part of the whole bug fix vnext backport .net 7 debate and highlights the struggles I bump into with regard to bugs.

Should we be able to Inherit from the current handler and fix the effected calls in someway shape or form? It isn't possible currently due to how its designed but It would be great if we could simply override specific methods etc.

public class MyFixedHandler : ScrollViewHandler
{
   protected override ArrangeScrollViewContent(){
....
}

}

It's not even possible to copy the whole handler and have it in your own project as ContentView.CrossPlatformArrange is also internal.

If the policy is not to fix long standing bugs in the current version, please make it more open for .net 8 so people can fix their own without compiling from source (Change private to protected and stop using internal).

[hartez]

Should we be able to Inherit from the current handler and fix the effected calls in someway shape or form? It isn't possible currently due to how its designed but It would be great if we could simply override specific methods etc.

You have a couple options - you can modify the mappings themselves (in your example, probably the Content mapping), or you can replace the entire handler. Take a look at this article: Customize controls with handlers.

[rmarinho]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 2 pipeline(s).

[cat0363]

Applying this PR will also resolve Issue #14795.
With this PR, Gestures now work as intended.

[azure-pipelines]

Commenter does not have sufficient privileges for PR 15460 in repo dotnet/maui

[jadenrogers]

@hartez Is there anything I need to do here? Feedback etc.

[PureWeen]

/azp run

[azure-pipelines]

No commit pushedDate could be found for PR 15460 in repo dotnet/maui

[rmarinho]

/azp run

[azure-pipelines]

No commit pushedDate could be found for PR 15460 in repo dotnet/maui

[rmarinho]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 3 pipeline(s).

[rmarinho]

I think is a good case do add a UITest for this one.

[jadenrogers]

I think is a good case do add a UITest for this one.

@rmarinho Is that something that needs to be done now with this PR or in a separate one?

[rmarinho]

@jadenrogers can you test with the new changes from main? seem if it fixes the issue or if we still need that fix, we made some changes recently.

0047ca2

[PureWeen]

@jadenrogers we have some docs here on how to add a UITest
https://github.com/dotnet/maui/blob/main/docs/design/UITesting.md

If you don't have bandwidth to add tests just let us know and we'll take care of it. If the docs are confusing let us know and we'll improve them!

[jadenrogers]

@jadenrogers we have some docs here on how to add a UITest https://github.com/dotnet/maui/blob/main/docs/design/UITesting.md

If you don't have bandwidth to add tests just let us know and we'll take care of it. If the docs are confusing let us know and we'll improve them!

On it, hope to check in later today

[jadenrogers]

@jadenrogers can you test with the new changes from main? seem if it fixes the issue or if we still need that fix, we made some changes recently.

0047ca2

Yes the issue is fixed. New issue the content never shrinks.