-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip tests currently having issues on WinUI #15527
Changes from all commits
0ea77ad
5d59f25
b4776aa
f4e0c86
5f6d1d0
d9ae542
bac406d
e3337fc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,7 +54,7 @@ await CreateHandlerAndAddToWindow<LayoutHandler>(layout, (handler) => | |
}); | ||
} | ||
|
||
[Fact] | ||
[Fact(Skip = "FIX FOR .NET8")] | ||
public async Task ValidateItemContainerDefaultHeight() | ||
{ | ||
SetupBuilder(); | ||
|
@@ -101,7 +101,7 @@ void ValidateItemContainerStyle(CollectionView collectionView) | |
Assert.Equal(0d, minHeight); | ||
} | ||
|
||
[Fact] | ||
[Fact(Skip = "FIX FOR .NET8")] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
public async Task ValidateSendRemainingItemsThresholdReached() | ||
{ | ||
SetupBuilder(); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -164,7 +164,13 @@ await CreateHandlerAndAddToWindow<LayoutHandler>(layout, async handler => | |
|
||
public static IEnumerable<object[]> GenerateLayoutOptionsCombos() | ||
{ | ||
var layoutOptions = new LayoutOptions[] { LayoutOptions.Center, LayoutOptions.Start, LayoutOptions.End, LayoutOptions.Fill }; | ||
var layoutOptions = new LayoutOptions[] { | ||
|
||
#if !WINDOWS | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
LayoutOptions.Center, LayoutOptions.Start, LayoutOptions.End, | ||
#endif | ||
|
||
LayoutOptions.Fill }; | ||
|
||
foreach (var option in layoutOptions) | ||
{ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
using System.Threading.Tasks; | ||
using Microsoft.Maui.Controls; | ||
using Xunit; | ||
using Xunit.Sdk; | ||
|
||
namespace Microsoft.Maui.DeviceTests | ||
{ | ||
public partial class FrameHandlerTest | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
{ | ||
[Fact(DisplayName = "Clip Initializes ContainerView Correctly", Skip = "Failing")] | ||
public override Task ContainerViewInitializesCorrectly() | ||
{ | ||
return Task.CompletedTask; | ||
} | ||
|
||
[Fact(DisplayName = "ContainerView Remains If Shadow Mapper Runs Again", Skip = "Failing")] | ||
public override Task ContainerViewRemainsIfShadowMapperRunsAgain() | ||
{ | ||
return Task.CompletedTask; | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -154,7 +154,11 @@ await CreateHandlerAndAddToWindow<LayoutHandler>(layout, async (handler) => | |
}); | ||
} | ||
|
||
[Fact] | ||
[Fact | ||
#if WINDOWS | ||
(Skip = "Failing") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
#endif | ||
] | ||
public async Task NullTemplateDoesntCrash() | ||
{ | ||
SetupBuilder(); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -253,7 +253,11 @@ await CreateHandlerAndAddToWindow<WindowHandlerStub>(new Window(navPage), async | |
}); | ||
} | ||
|
||
[Fact(DisplayName = "NavigationPage Does Not Leak")] | ||
[Fact(DisplayName = "NavigationPage Does Not Leak" | ||
#if WINDOWS | ||
,Skip = "Failing" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
#endif | ||
)] | ||
public async Task DoesNotLeak() | ||
{ | ||
SetupBuilder(); | ||
|
@@ -291,7 +295,11 @@ await CreateHandlerAndAddToWindow<WindowHandlerStub>(new Window(navPage), async | |
Assert.False(pageReference.IsAlive, "Page should not be alive!"); | ||
} | ||
|
||
[Fact(DisplayName = "Can Reuse Pages")] | ||
[Fact(DisplayName = "Can Reuse Pages" | ||
#if WINDOWS | ||
,Skip = "Failing" | ||
#endif | ||
)] | ||
public async Task CanReusePages() | ||
{ | ||
SetupBuilder(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#15529