Windows (packaged) Device tests for CI #15629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
platform/windows 🪟
legacy-area-desktop
jfversluis
force-pushed
the
windows-ui-tests
branch
from
90034f9 to
75e2b0c
Compare
jfversluis
changed the title
jfversluis
commented
Jul 12, 2023
| <Identity | ||
| Name="2C0C8B63-C6D1-48CC-A934-5108983E28EE" | ||
| Publisher="CN=User Name" | ||
| Version="1.0.0.0" /> | ||
| <Identity Publisher="CN=User Name" /> |
There was a problem hiding this comment.
Not hardcoding this will make it pick up the application ID from the csproj through single project
| Name="2C0C8B63-C6D1-48CC-A934-5108983E28CB" | ||
| Name="maui-package-name-placeholder" |
There was a problem hiding this comment.
Not hardcoding this will make it pick up the application ID from the csproj through single project
jfversluis
force-pushed
the
windows-ui-tests
branch
from
1250eb3 to
525ea4f
Compare
32 tasks
|
See #15530 for a TODO list of tests and test projects we need to look at after this is merged |
jfversluis
force-pushed
the
windows-ui-tests
branch
from
a65caa7 to
0c5b390
Compare
mattleibow
reviewed
Jul 15, 2023
Comment on lines
+25
to
+26
|
|
||
| public static bool RunHeadless = false; |
There was a problem hiding this comment.
Not sure that this is still needed. No references in this PR.
Suggested change
| public static bool RunHeadless = false; |
mattleibow
reviewed
Jul 15, 2023
PureWeen
approved these changes
Jul 15, 2023
mattleibow
approved these changes
Jul 16, 2023
Redth
approved these changes
Jul 16, 2023
2 tasks
|
/backport to net7.0 |
|
Started backporting to net7.0: https://github.com/dotnet/maui/actions/runs/5572031588 |
|
@PureWeen backporting to net7.0 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Build & Run Packaged Windows DeviceTests
.git/rebase-apply/patch:156: trailing whitespace.
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
A eng/devices/windows.cake
M eng/pipelines/common/device-tests-steps.yml
M eng/pipelines/common/device-tests.yml
M eng/pipelines/device-tests.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/device-tests.yml
Auto-merging eng/pipelines/common/device-tests.yml
CONFLICT (content): Merge conflict in eng/pipelines/common/device-tests.yml
Auto-merging eng/pipelines/common/device-tests-steps.yml
CONFLICT (content): Merge conflict in eng/pipelines/common/device-tests-steps.yml
CONFLICT (modify/delete): eng/devices/windows.cake deleted in HEAD and modified in Build & Run Packaged Windows DeviceTests. Version Build & Run Packaged Windows DeviceTests of eng/devices/windows.cake left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Build & Run Packaged Windows DeviceTests
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@PureWeen an error occurred while backporting to net7.0, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
jfversluis
added a commit
that referenced
this pull request
Aug 15, 2023
* Build & Run Packaged Windows DeviceTests * Disable running for Core * Skip failing tests * Skip Launcher tests * Update Launcher_Tests.cs * Update windows.cake * Revert "Update windows.cake" This reverts commit f94dfdd. * Update windows.cake
github-actions bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
* Build & Run Packaged Windows DeviceTests * Disable running for Core * Skip failing tests * Skip Launcher tests * Update Launcher_Tests.cs * Update windows.cake * Revert "Update windows.cake" This reverts commit f94dfdd. * Update windows.cake
github-actions bot
pushed a commit
that referenced
this pull request
Aug 21, 2023
* Build & Run Packaged Windows DeviceTests * Disable running for Core * Skip failing tests * Skip Launcher tests * Update Launcher_Tests.cs * Update windows.cake * Revert "Update windows.cake" This reverts commit f94dfdd. * Update windows.cake
jfversluis
added a commit
that referenced
this pull request
Aug 22, 2023
* Windows (packaged) Device tests for CI (#15629) * Build & Run Packaged Windows DeviceTests * Disable running for Core * Skip failing tests * Skip Launcher tests * Update Launcher_Tests.cs * Update windows.cake * Revert "Update windows.cake" This reverts commit f94dfdd. * Update windows.cake * Enable WinUI Core Tests on CI (#15885) * Fix WinUI test issues * - enable core tests * - core test fixes * - ignore semantics tests * - fix * - syntax errors * Correct merge mistake * Make it work? * Fix some tests * Fix WebView tests * Essentials & Graphics Windows app id fix * Update TestUtils.DeviceTests.Runners.csproj * Revert "Update TestUtils.DeviceTests.Runners.csproj" This reverts commit bec734e. * Set correct TFMs for DeviceTests --------- Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
Eilon
added
t/desktop
samhouts
added
the
fixed-in-8.0.0-preview.7.8842
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables automated DeviceTests for packaged Windows apps for the following projects:
We should also enable
/src/Controls/tests/DeviceTests/Controls.DeviceTests.csproj&/src/Core/tests/DeviceTests/Core.DeviceTests.csproj, but that one seems to crash right now so that needs some work.This PR adds the plumbing to run these tests through the pipeline and publish the test results.
Once this is merged we still need:
This is tracked by #15530