Fix events not firing for Scrolled and RemainingItemsThresholdReached
#15658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hed` for CollectionView on Windows
Foda
added
platform/windows 🪟
area-controls-collectionview
Foda
commented
Jun 14, 2023
| @@ -54,12 +54,19 @@ protected override ListViewBase CreatePlatformView() | |||
| protected override void ConnectHandler(ListViewBase platformView) | |||
| { | |||
| base.ConnectHandler(platformView); | |||
| FindScrollViewer(platformView); | |||
There was a problem hiding this comment.
This was all that was needed -- FindScrollViewer I think was accidentally removed
jsuarezruiz
approved these changes
Jun 15, 2023
|
isn't this #15555 ? |
DANGIT |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix events not firing for
ScrolledandRemainingItemsThresholdReachedfor CollectionView on Windows (regression via #15601)Issues Fixed
Fixes #15529
CC #14391