[net8.0] Update dependencies from xamarin/xamarin-android #16024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dotnet-maestro[bot]](https://avatars.githubusercontent.com/in/16706?s=60&v=4){kind=small}
…uild main-47087d5604645103786ff19b39dd04474d05dd0b-1 Microsoft.Android.Sdk.Windows From Version 34.0.0-preview.7.361 -> To Version 34.0.0-preview.7.362
ghost
added
the
area-infrastructure
jsuarezruiz
approved these changes
Jul 7, 2023
…uild main-a850d8147d6c1d066f3849e7cf8fab231497c64b-1 Microsoft.Android.Sdk.Windows From Version 34.0.0-preview.7.361 -> To Version 34.0.0-preview.7.365 Dependency coherency updates Microsoft.Dotnet.Sdk.Internal,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.100-preview.7.23325.5 -> To Version 8.0.100-preview.7.23330.16 (parent: Microsoft.Android.Sdk.Windows
jonathanpeppers
approved these changes
Jul 11, 2023
…uild main-f21e10deed466c71713e1b35dbc8a327880c2c7c-1 Microsoft.Android.Sdk.Windows From Version 34.0.0-preview.7.361 -> To Version 34.0.0-preview.7.367 Dependency coherency updates Microsoft.Dotnet.Sdk.Internal,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.100-preview.7.23325.5 -> To Version 8.0.100-preview.7.23330.16 (parent: Microsoft.Android.Sdk.Windows
…uild main-76ab8b2ca208a73834c70453193e5ec7ef1f7304-1 Microsoft.Android.Sdk.Windows From Version 34.0.0-preview.7.361 -> To Version 34.0.0-preview.7.369 Dependency coherency updates Microsoft.Dotnet.Sdk.Internal,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.100-preview.7.23325.5 -> To Version 8.0.100-preview.7.23330.16 (parent: Microsoft.Android.Sdk.Windows
…uild main-a016b31a88a78bc67a8a33edeabbf92a4dc28c71-1 Microsoft.Android.Sdk.Windows From Version 34.0.0-preview.7.361 -> To Version 34.0.0-preview.7.371 Dependency coherency updates Microsoft.Dotnet.Sdk.Internal,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.100-preview.7.23325.5 -> To Version 8.0.100-preview.7.23330.16 (parent: Microsoft.Android.Sdk.Windows
…uild main-26ffd5d763b36dde528bc324967f4925e9101733-1 Microsoft.Android.Sdk.Windows From Version 34.0.0-preview.7.361 -> To Version 34.0.0-preview.7.374 Dependency coherency updates Microsoft.Dotnet.Sdk.Internal,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.100-preview.7.23325.5 -> To Version 8.0.100-preview.7.23330.16 (parent: Microsoft.Android.Sdk.Windows
|
|
I think the latest error is caused by: dotnet/android@26ffd5d It adds We should be passing |
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Jul 18, 2023
Context: dotnet/maui#16024 (comment) .NET MAUI's build currently fails with: Xamarin.Android.Aapt2.targets(123,3): error APT2144: invalid file path 'D:\a\_work\1\s\src\Core\src\obj\Debug\net8.0-android\lp\129.stamp'. What is very wrong about this, it is trying to `aapt2 compile` a `*.stamp` file: Executing compile -o /Users/builder/azdo/_work/1/s/src/Core/src/obj/Release/net8.0-android/lp/87/jl/res/../flat/ /Users/builder/azdo/_work/1/s/src/Core/src/obj/Release/net8.0-android/lp/87.stamp Normally this runs against `*.flat` or `*.flata` files. This problem was introduced in 26ffd5d: 1. Library A uses an AndroidX package, the AndroidX `.aar` file is added to `@(AndroidAarLibrary)`. The NuGet package does this in a `.targets` file. 2. With the change in 26ffd5d, the `.aar` is copied to Library A's build output. 3. Library B uses the same AndroidX package and references Library A. 4. Library B now has duplicate `.aar` files & has the weird build error! I could reproduce the issue in a test. There *may* be a second bug here, but we should update our logic to be: <!-- .aar files should be copied to $(OutputPath) in .NET 6--> <None Include="@(AndroidLibrary)" Condition=" '%(AndroidLibrary.Extension)' == '.aar' " ... /> <!-- @(LibraryProjectZip) items that are not in @(AndroidLibrary) --> <None Include="@(LibraryProjectZip)" Exclude="@(AndroidLibrary)" ... /> So we now only copy: * The new `@(AndroidLibrary)` item group with an `.aar` extension. *Not* `@(AndroidAarLibrary)`. * Any `@(LibraryProjectZip)` that are *not* in `@(AndroidLibrary)`. This supports the classic item group name, keeping our behavior before. Now the new test and the test updated in 26ffd5d both pass.
jonathanpeppers
added a commit
to dotnet/android
that referenced
this pull request
Jul 19, 2023
Context: dotnet/maui#16024 (comment) .NET MAUI's build currently fails with: Xamarin.Android.Aapt2.targets(123,3): error APT2144: invalid file path 'D:\a\_work\1\s\src\Core\src\obj\Debug\net8.0-android\lp\129.stamp'. What is very wrong about this, it is trying to `aapt2 compile` a `*.stamp` file: Executing compile -o /Users/builder/azdo/_work/1/s/src/Core/src/obj/Release/net8.0-android/lp/87/jl/res/../flat/ /Users/builder/azdo/_work/1/s/src/Core/src/obj/Release/net8.0-android/lp/87.stamp Normally this runs against `*.flat` or `*.flata` files. This problem was introduced in 26ffd5d: 1. Library A uses an AndroidX package, the AndroidX `.aar` file is added to `@(AndroidAarLibrary)`. The NuGet package does this in a `.targets` file. 2. With the change in 26ffd5d, the `.aar` is copied to Library A's build output. 3. Library B uses the same AndroidX package and references Library A. 4. Library B now has duplicate `.aar` files & has the weird build error! I could reproduce the issue in a test. There *may* be a second bug here, but we should update our logic to be: <!-- .aar files should be copied to $(OutputPath) in .NET 6--> <None Include="@(AndroidLibrary)" Condition=" '%(AndroidLibrary.Extension)' == '.aar' " ... /> <!-- @(LibraryProjectZip) items that are not in @(AndroidLibrary) --> <None Include="@(LibraryProjectZip)" Exclude="@(AndroidLibrary)" ... /> So we now only copy: * The new `@(AndroidLibrary)` item group with an `.aar` extension. *Not* `@(AndroidAarLibrary)`. * Any `@(LibraryProjectZip)` that are *not* in `@(AndroidLibrary)`. This supports the classic item group name, keeping our behavior before. Now the new test and the test updated in 26ffd5d both pass.
…uild main-3a89e8d87afe1fa68744b0cf427d748dd42db51a-1 Microsoft.Android.Sdk.Windows From Version 34.0.0-preview.7.361 -> To Version 34.0.0-preview.7.376 Dependency coherency updates Microsoft.Dotnet.Sdk.Internal,Microsoft.NETCore.App.Ref,Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100.Transport From Version 8.0.100-preview.7.23325.5 -> To Version 8.0.100-preview.7.23330.16 (parent: Microsoft.Android.Sdk.Windows
rmarinho
approved these changes
Jul 20, 2023
|
We should try hard to merge this one today. I just merged a .NET bump where a lot of things broke: I suspect you're going to have to do some work to fix the MAUI build for the next one... |
|
yeah that why I wanted also net8.0 green. so we could merge easier . I m on it |
samhouts
added
the
fixed-in-8.0.0-preview.7.8842
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the following dependencies
From https://github.com/xamarin/xamarin-android
Coherency Updates
The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format