-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[net8.0] Build the previous TFM for Essentials & Graphics #17042
Conversation
5d53f23
to
ff8ca5f
Compare
/rebase |
Currently, Graphics and Essentials are really usable outside of .NET MAUI and .NET is still in support so we need to also make sure they get serviced. This will allow for independent features to be added without being tied to the .NET MAUI SDK.
ff8ca5f
to
1a7514a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the main thing missing, is some test that make sure these new assemblies actually work?
Is there a way to run one of the associated unit test projects under the previous target framework? It doesn't seem like it would slow down CI that much, as the unit tests are fast.
@mattleibow @pjcollins since we have the integration tests, we could add the package for net7 there right? Makea test that make sure the package is installed and used on net7.0? I think we can create a new issue to track that work and merge this to get to net8 ga. |
@rmarinho I think the integration test project could be a reasonable place to add tests for this, but I also like @jonathanpeppers suggestion of trying to get the existing unit tests running against the previous target. |
Description of Change
Currently, Graphics and Essentials are really usable outside of .NET MAUI and .NET is still in support so we need to also make sure they get serviced. This will allow for independent features to be added without being tied to the .NET MAUI SDK.
This, however, will not work with a .NET 7 MAUI app because that uses workloads and pins the AndroidX packages - and they are NOT compatible in any way. Google breaks minor versions on pretty much every release so we cannot get this nice feature.