Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[net8.0] Build the previous TFM for Essentials & Graphics #17042

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

mattleibow
Copy link
Member

@mattleibow mattleibow commented Aug 28, 2023

Description of Change

Currently, Graphics and Essentials are really usable outside of .NET MAUI and .NET is still in support so we need to also make sure they get serviced. This will allow for independent features to be added without being tied to the .NET MAUI SDK.

This, however, will not work with a .NET 7 MAUI app because that uses workloads and pins the AndroidX packages - and they are NOT compatible in any way. Google breaks minor versions on pretty much every release so we cannot get this nice feature.

@mattleibow mattleibow requested a review from a team as a code owner August 28, 2023 23:22
@mattleibow mattleibow marked this pull request as draft August 29, 2023 01:08
@mattleibow mattleibow changed the title Build the previous .NET version of some nugets [net8.0] Build the previous .NET version of some nugets Aug 29, 2023
@samhouts samhouts added this to the Under Consideration milestone Aug 31, 2023
@mattleibow mattleibow changed the title [net8.0] Build the previous .NET version of some nugets [net8.0] Build the previous TFM for Essentials & Graphics Sep 1, 2023
@mattleibow mattleibow marked this pull request as ready for review September 13, 2023 15:43
@mattleibow
Copy link
Member Author

/rebase

Currently, Graphics and Essentials are really usable outside of .NET MAUI and
.NET is still in support so we need to also make sure they get serviced. This
will allow for independent features to be added without being tied to the
.NET MAUI SDK.
@samhouts samhouts modified the milestones: Under Consideration, .NET 8 GA Sep 19, 2023
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the main thing missing, is some test that make sure these new assemblies actually work?

Is there a way to run one of the associated unit test projects under the previous target framework? It doesn't seem like it would slow down CI that much, as the unit tests are fast.

@rmarinho
Copy link
Member

@mattleibow @pjcollins since we have the integration tests, we could add the package for net7 there right? Makea test that make sure the package is installed and used on net7.0?

I think we can create a new issue to track that work and merge this to get to net8 ga.

@pjcollins
Copy link
Member

@rmarinho I think the integration test project could be a reasonable place to add tests for this, but I also like @jonathanpeppers suggestion of trying to get the existing unit tests running against the previous target.

@PureWeen PureWeen modified the milestones: .NET 8 GA, .NET 8 SR1 Sep 28, 2023
@rmarinho rmarinho merged commit d02f597 into net8.0 Oct 4, 2023
@rmarinho rmarinho deleted the dev/previous-bcl branch October 4, 2023 10:35
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
@samhouts samhouts added the fixed-in-8.0.0-rc.2.9511 Look for this fix in 8.0.0-rc.2.9511 label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-8.0.0-rc.2.9511 Look for this fix in 8.0.0-rc.2.9511
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants