Grid rows ios fix #17199
Closed
Grid rows ios fix #17199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up the full expansion check by removing the maxCurrentSize calculation (which is no longer used), and using a boolean instead of minimum star size so that we can exit the check early if the fit test fails.
Uses a distribution method similar to that used previously in the ExpandStars method in the DetermineMinimumStarSizesInSpan method to better distribute the space needed among the rows/columns.
Refactored star distribution code to allow both methods to use common code.
ghost
added
the
|
Hey there @john-hollander! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
/azp run MAUI-DeviceTests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Eilon
added
the
area-layout
|
I'm wondering why this fix isn't getting attention from the Maui team. My respect to @john-hollander for his work. Had to replace the GridLayoutManager code with his to address existing grid issues. |
rmarinho
added a commit
that referenced
this pull request
Oct 16, 2023
…17880) ### Description of Change For constrained measurement, when definition sizes are determined during the measure pass the star sizes are limited by the number of stars which can fit into the constraint. During arrange, if the actual arrange size is different, then the size of a star definition needs to be limited by the number of stars which can fit into the arranged size. Proposing this as an alternative to #17199 - this is a less extensive change to achieve the same effect. ### Issues Fixed Fixes #17125
|
Hey @john-hollander thank you for your contribution, after looking more a the issue @hartez has found a less intrusive change to the codebase here #17880 . So we are closing this one for now, but if we still have issues we can review this changes again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Adjusted the DetermineMinimumStarSizesInSpan function to distribute the space needed relative to the target sizes associated with the star values using the same method as the ExpandStars method.
In the Measure method, the height constraint doesn't take the safe area into consideration for iOS, and this results in the Size value of the definitions to be higher than what is actually available in the safe area for each row. Then when the DetermineMinimumStarSizesInSpan was called with dimensions that were consistent with the safe area, it would apportion the space needed among the star rows without regard for how much of the Minimum size already existed for a row.
In the test code, this occurs when splitting the space needed into the second and third rows. The first row wasn't affected, so its height was the optimal, but the second row already had an optimal value and the third was empty. The old method made it such that the rows were 1.0, 1.5, 0.5 optimal height respectively, and then the second row was truncated to the optimal value that it would be without the safe area taken into account (so, slightly larger than optimal). The new method splits the space needed with the star sizes taken into account, and results in the rows being 1.0, 1.0, 1.0 optimal height respectively, consistent with the safe area.
As a result, the values sent into the ExpandStars method no longer include sizes that are inconsistent with the safe area, and now produce the expected results.
Issues Fixed
Fixes #17125