-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sealed
some internal
classes in Controls.Core
that are not inherited from (1)
#17669
Conversation
Hey there @Lehonti! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
What problem are you trying to solve with this? |
There is no problem as such. I am just trying to make the code easier to read and understand, and with less pitfalls (if a programmer sees that a class is unsealed, they may think that it's prepared to handle scenarios that it actually has not been planned for). |
Additionally I heard of this: https://www.meziantou.net/performance-benefits-of-sealed-class.htm |
@jonathanpeppers is this something we should consider from a perf standpoint? |
It would help a very small amount, but if these are |
/azp run MAUI-UITests-public |
Azure Pipelines successfully started running 1 pipeline(s). |
Description of Change
Sealed some classes. They are not part of the public API, but this change can help us better track code invariants