Run template tests run in parallel to save 15min of run time #17672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eilon
added
do-not-merge
Eilon
force-pushed
the
eilon/parallel-templates
branch
from
156560f to
419a2af
Compare
Eilon
commented
Sep 29, 2023
| @@ -1,16 +1,19 @@ | |||
| using Microsoft.Maui.IntegrationTests.Apple; | |||
|
|
|||
| [assembly: LevelOfParallelism(2)] | |||
There was a problem hiding this comment.
This is the key part of the change. Can adjust in the future higher/lower.
Eilon
changed the title
Eilon
commented
Sep 29, 2023
Comment on lines
+61
to
+62
| var projectName = DotnetInternal.GetProjectName(projectDir); | ||
| var projectFile = Path.Combine(projectDir, $"{projectName}.csproj"); |
There was a problem hiding this comment.
This change and other projectName stuff is repeated for nearly every test: it's what ensures that the lengthy project names used throughout the tests are not too long for WinUI AppX (see PR description for more info).
|
@ruiminhu / @PureWeen / @mattleibow - any thoughts on getting this in? I see this as potentially improving our engineering lives by not only getting test results quite a bit faster, but potentially shorter queue times as well. |
samhouts
approved these changes
Oct 16, 2023
rmarinho
approved these changes
Oct 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like maybe yes! I set a max of 2 threads parallel because that seems to get significant gains (15min faster!) and so far seems reliable.
Here are examples of build times from a few random builds without the change and the last one is with the change in this PR:
Attempt 1 from this PR - about 15min faster!!!
Attempt 2 from this PR - about 15min faster!!!
And more historical data available in build analytics (go to https://dev.azure.com/xamarin/public/_pipeline/analytics/duration?definitionId=57&contextType=build, filter Stages by
Test Templates):And the times range from 51min-59min over the last two weeks.
I propose that we take this change to significantly improve build times. We can later consider cranking up the parallelization level and see if it remains reliable. Or, if it seems to make things flaky, it's easy to set it to 1 thread.
This PR includes a few related changes:
Buildmauilibnet60DebugTrue\id01039Buildmauilibnet60DebugTrue.csproj). In this change the project names are shortened if necessary to prevent issues. As part of (2) to make super-unique names, I caused names to just barely exceed the max length, so (3) became necessary.