Fail UI test run when all tests are inconclusive #17971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 12, 2023
PureWeen
approved these changes
Oct 12, 2023
mattleibow
approved these changes
Oct 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
After upgrading our UITest dependency to a new version suddenly all tests would pass on iOS. Upon further inspection we noticed that the tests in fact didn't run, but they were all marked inconclusive. However, that would not fail the test run/pipeline and so the no running of tests might go undetected.
This adds a safeguard that looks at the test results XML file and check if the number of total tests ran and the number of inconclusive tests are the same. If they are, no tests ran and we thrown an exception.
Issues Fixed
Fixes #17945
Related
#17931