Setup legacy mappers #18087
Merged
Setup legacy mappers #18087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
commented
Oct 18, 2023
PureWeen
force-pushed
the
account_for_legacy_mappers
branch
from
ef0f6cf to
7013783
Compare
PureWeen
force-pushed
the
account_for_legacy_mappers
branch
from
7013783 to
72437c2
Compare
hartez
approved these changes
Oct 24, 2023
|
/backport to release/8.0.1xx-rc2.2 |
|
Started backporting to release/8.0.1xx-rc2.2: https://github.com/dotnet/maui/actions/runs/6631559086 |
samhouts
added
the
fixed-in-8.0.100-rc.2.9530
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We obsoleted the
ControlsMappersbecause they were causing issues when the application was AOT'd #13836. This change disconnected the controls mappers completely from the core mappers, which meant that if someone was wiring into these their code would stop executing.This PR takes a minimal approach to proxy mapper modifications from the
ControlsMapperto theCoremappers in order to not break users when they update to NET8.If someone is wiring into the
ControlsMappersinsideMauiProgrambefore any of the builder extension methods are called their code still won't run. That path was already unreliable and broken with AOT.Issues Fixed
Fixes #18059