Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix Border clipping issues #18134

Closed
wants to merge 8 commits into from
Closed

[Android] Fix Border clipping issues #18134

wants to merge 8 commits into from

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

(Work in progress)

Fix Border clipping issues on Android.
issue-border-droid

The issue mentions problems in Windows, but I can't reproduce them.
fix-18071-win

Added a golden test to validate this scenario.

Issues Fixed

Fixes #18071

@jsuarezruiz jsuarezruiz added t/bug Something isn't working platform/android 🤖 area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing area-controls-border Border labels Oct 19, 2023
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Oct 19, 2023
@jsuarezruiz
Copy link
Contributor Author

Added another test to validate the Border with different shapes and strokes
image

@samhouts samhouts added the s/pr-needs-author-input PR needs an update from the author label Oct 23, 2023
@dotnet dotnet deleted a comment Oct 24, 2023
@jonmdev
Copy link

jonmdev commented Oct 29, 2023

Does this fix by any chance also fix this issue?

#17882

It would be really great to get a fix for that too. If both these are fixed we can get consistent predictable layouts with Borders which is really critical for putting out any projects using Borders. It would help a lot.

Currently, between both of these bugs it is very hard to know how anything will look on any given platform or consistently control it.

@jonmdev
Copy link

jonmdev commented Oct 30, 2023

Also, I hate to pile on, but I just remembered in iOS we also have this pretty bad bug, which I think might be due to automatic iOS animation tweening of the object preventing it from reaching the target size immediately:

#18204

If we could get all three of these fixed (the masking, the drawing to the edges, and the iOS lagging) Border would be pretty solid for use and it would be appreciated. Thanks again.

@ghost
Copy link

ghost commented Nov 9, 2023

Hi @jsuarezruiz.
It seems you haven't touched this PR for the last two weeks. To avoid accumulating old PRs, we're marking it as stale. As a result, it will be closed if no further activity occurs within 4 days of this comment. You can learn more about our Issue Management Policies here.

@ghost ghost added the stale Indicates a stale issue/pr and will be closed soon label Nov 9, 2023
@ghost ghost closed this Nov 14, 2023
@activa
Copy link
Contributor

activa commented Nov 17, 2023

Your test shows this:

chrome_2023-11-16_21-35-44

That's not how it's supposed to render though. The border is cut off in the rounded corners.

This is more obvious in the following test case:
qemu-system-x86_64_2023-11-16_21-37-06

On Windows and iOS it renders correctly:

MauiApp8-1_2023-11-16_21-38-00

The above is using the following XAML:

<Border Stroke="Black" StrokeThickness="8"
        StrokeShape="RoundRectangle 30,0,0,30" 
        WidthRequest="200" HeightRequest="200">
    <Grid RowDefinitions="Auto,*" >
        <BoxView Color="Red" Grid.Row="0" HeightRequest="50"/>
        <BoxView Color="Green" Grid.Row="1" />
    </Grid>
</Border>

@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-border Border area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing platform/android 🤖 s/pr-needs-author-input PR needs an update from the author stale Indicates a stale issue/pr and will be closed soon t/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[regression/8.0.0] Windows and Android no longer draw Borders/clipping correctly (previously was okay)
5 participants