Add/Remove CarouselView Layout Listener when view is add/removed from window #18771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
requested review from
StephaneDelcroix and
hartez
and removed request for
StephaneDelcroix
PureWeen
changed the title
PureWeen
changed the title
PureWeen
commented
Nov 15, 2023
| protected override void OnAttachedToWindow() | ||
| { | ||
| base.OnAttachedToWindow(); | ||
| AddLayoutListener(); |
There was a problem hiding this comment.
I do wonder if we want this to be a layout listener. Global Layout Listeners fire for everything, so any changes to the layout anywhere causes the code inside the CV to execute. Maybe that's the intent? It does seem a little excessive.
|
Can you test the changes here in this app?
If it works and you see |
mattleibow
reviewed
Nov 15, 2023
src/Controls/src/Core/Handlers/Items/Android/MauiCarouselRecyclerView.cs
Outdated
Show resolved
Hide resolved
|
jonathanpeppers
approved these changes
Nov 16, 2023
rmarinho
approved these changes
Nov 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
#18584 modified the
CarouselViewOnGlobalLayoutListenerso that it only retains a weak reference to the recycler view. Because this layout listener no longer participates in keeping theCarouselViewfrom being collected there's a chance that it could still get triggered from android.We also need to tie the lifetime of the
CarouselViewOnGlobalLayoutListenerto something otherwise it will continue to fire even beyond the lifetime of theCarouselView.BecauseGlobalLayoutListenersare added to theViewTreeObserverthey are essentially being added to a resilient static container. This PR makes it so theGlobalLayoutListeneris only added when theCarouselViewis part of the Visual Tree.Issues Fixed
Fixes #18733