[X] Warn on non compiled bindings #19360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDelcroix
force-pushed
the
WarnOnNonCompiledBindings
branch
from
e460eef to
d5bc45c
Compare
StephaneDelcroix
force-pushed
the
WarnOnNonCompiledBindings
branch
5 times, most recently
from
f965259 to
5c3394e
Compare
simonrozsival
previously approved these changes
Dec 15, 2023
rmarinho
reviewed
Dec 15, 2023
| @@ -389,13 +389,18 @@ static IEnumerable<Instruction> CompileBindingPath(ElementNode node, ILContext c | |||
| n = n.Parent as IElementNode; | |||
| } | |||
|
|
|||
| if (dataTypeNode is null) | |||
| if (dataTypeNode is null) { | |||
| context.LoggingHelper.LogWarningOrError(10101, context.XamlFilePath, node.LineNumber, node.LinePosition, 0, 0, $"Binding could be compiled if x:DataType is specified", null); | |||
There was a problem hiding this comment.
Should these codes be documented somewhere ? or references from a static that has documentation about these numbers?
rmarinho
reviewed
Dec 15, 2023
StephaneDelcroix
force-pushed
the
WarnOnNonCompiledBindings
branch
from
5c3394e to
8ad1b2f
Compare
|
@StephaneDelcroix I think this needs another rebase now right? |
StephaneDelcroix
force-pushed
the
WarnOnNonCompiledBindings
branch
from
8ad1b2f to
4e84a1e
Compare
|
@rmarinho y, done |
|
/rebase |
github-actions
bot
force-pushed
the
WarnOnNonCompiledBindings
branch
from
4e84a1e to
dd73647
Compare
StephaneDelcroix
force-pushed
the
WarnOnNonCompiledBindings
branch
from
dd73647 to
e702845
Compare
|
/rebase |
When XamlC can't compile a Binding due to missing x:DataType, log a warning. If you use TreatWarningsAsErrors, add XC10101 to WarningsNotAsErrors to avoid the build failing
github-actions
bot
force-pushed
the
WarnOnNonCompiledBindings
branch
from
e702845 to
35bbb34
Compare
rmarinho
approved these changes
Dec 20, 2023
Eilon
added
the
t/perf
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
When XamlC can't compile a Binding due to missing x:DataType, log a
warning.
If you use TreatWarningsAsErrors, add XC0022 and XC0023 to WarningsNotAsErrors to
avoid the build failing
Issues Fixed
! this is based on top of #19337. Merge that one then rebase.
Fixes #