Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes dead code from type conversion #19436

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Removes dead code from type conversion #19436

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions src/Controls/src/Core/Xaml/TypeConversionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,19 +172,6 @@ internal static object ConvertTo(this object value, Type toType, Func<TypeConver
return null;
}

if (converter != null)
{
try
{
return converter.ConvertFromInvariantString(str);
}
catch (Exception e)
{
exception = new XamlParseException("Type conversion failed", serviceProvider, e);
return null;
}
}

var ignoreCase = (serviceProvider?.GetService(typeof(IConverterOptions)) as IConverterOptions)?.IgnoreCase ?? false;

//If the type is nullable, as the value is not null, it's safe to assume we want the built-in conversion
Expand Down
Loading