iOS Keyboard Scrolling - Maui Community Toolkit Popup #19765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing-Improvements1
…ing-Improvements1
…ing-Improvements1
…ing-Improvements1
tj-devel709
added
platform/iOS 🍎
legacy-area-controls
samhouts
removed
the
legacy-area-controls
|
Closing for now until making more progress with MCT testing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MCT popup code was originally here, but moved to here so that the testing of the popup could be implemented without blocking the other parts of the PR.
MCT Popup
The iOS Keyboard Scrolling solution I posted a few months ago had an issue with the Maui Community Toolkit Popup. The main issue was that the popup has some external scrolling going on. The Maui code would grab the initial position of the cursor, the external scrolling would happen, and then our Maui code would scroll from the initial position making things messy and incorrect. The solution I came up with is refactoring the portion of the code that calculates where the cursor on the editor/entry is to later in the code and monitoring the ContainerView to see if there was a change in position and allotting time until this external scrolling is finished to start our scroll calculations. This should also help in future situations where we are not able to control an external scroll.
MCT Popup Example (click me!)
PopupScroll-Before.mov
PopupScroll-After.mov
Issues Fixed
Fixes PureWeen/ShanedlerSamples#13