-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix modal page push in immersive mode #19903
Conversation
Hey there @PavloLukianets! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Changed the pr a bit, less additional calls and code now. Also, i was thinking about fixing #18033 , but the only way for it to work that i've figured out is to check if the bar's color is |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
@PureWeen was there a reason to use |
Hi all, Please, can you send some updates about the delay of approval for this bug fix? |
I think the right fix here is to convert modals to using DialogFragments instead of adding it to the decorView I spiked that path forever ago Not sure if it still compiles :-) but my gut tells me that would just make modals work more naturally overall. |
Failing test unrelated |
* Fix modal page push in immersive mode * Change GetInsetsIgnoringVisibility to GetInsets * Revert "Fix modal page push in immersive mode" This reverts commit a2526ea.
* Fix modal page push in immersive mode * Change GetInsetsIgnoringVisibility to GetInsets * Revert "Fix modal page push in immersive mode" This reverts commit a2526ea.
* Fix modal page push in immersive mode * Change GetInsetsIgnoringVisibility to GetInsets * Revert "Fix modal page push in immersive mode" This reverts commit a2526ea.
Issues Fixed
Fixes #10364
Description of Change
Fix modal page push in immersive mode
untitled.webm