[iOS] Fixes carouselview layout on iOS #20001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hey there @NielsKnaap! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
|
@dotnet-policy-service agree |
Eilon
added
the
area-controls-collectionview
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
hi @rmarinho, why are some of the pipelines failing? Can I do something about it? |
NielsKnaap
changed the title
|
@rmarinho @mattleibow, Is there anything to be done for this PR? |
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
rmarinho
approved these changes
Feb 7, 2024
mattleibow
approved these changes
Feb 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
After this fix #14951 (#15652) to make to collectionview get the size of its contents instead of filling the whole screen, the size of the carouselview was impacted aswell. This introduced some layout bugs with the carouselview on iOS.
This PR will make sure the carouselview will use the default implementation of the GetDesiredSize() method.
Issues Fixed
Before
Screen.Recording.2024-01-19.at.11.28.56.mov
Screen.Recording.2024-01-19.at.11.38.13.mov
After
Screen.Recording.2024-01-19.at.11.26.59.mov
Screen.Recording.2024-01-19.at.11.39.04.mov