Revert "Remove unused functions (#20029)" #20050
Conversation
This reverts commit b4bc1c8.
|
In that case, the IndexOf function should ideally receive the same 4 lines of code as in PR #19963 It may help improve HotReload performance and memory usage. |
Sure, I'm happy to switch it to a new method or whatever needs to happen. But the removed method was accessed in code currently shipping in Visual Studio (for several releases), and that PR broke a shipping product. That method should be labeled obsolete instead of removed, so it won't retroactively break Visual Studio. Right now, I just want to make sure we don't break customers. e. To be clear, I don't blame anyone for not knowing those extension methods were being used outside of this source repo, especially since they are in an Internal class (to which partner extensions like ours have access). This speaks to a broader problem of not having tests for dependencies like ours run inside of this repo as part of its test run, so that you could have saw the breakage (outside of running the MAUI source projects inside of Visual Studio with XAML Hot Reload enabled, which also would have shown the exception) |
| @@ -20,6 +20,29 @@ public static void ForEach<T>(this IEnumerable<T> enumeration, Action<T> action) | |||
| } | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// | |||
There was a problem hiding this comment.
This is reverting the already existing code.
|
Yeah just to add that this is an Internal api and that's why removing didn't broke the PublicAPI . But I agree we should add a some comment saying why this is used and mark ir as Obsolete in a next PR, can we do that @drasticactions ? |
|
@rmarinho @mattleibow I've made a new PR to add the tags #20068 |
This reverts commit b4bc1c8.
This code was used by XAML Hot Reload, which is injected into an MAUI Application after the fact. The code for it is not contained within this repo, so it's not represented as being "used," but it is very much part of the API we need.
Description of Change
Revert the commit to add back the needed methods.
Issues Fixed
Fixes #20049