Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Enabling ignored tests #20129

Merged
merged 8 commits into from
Feb 2, 2024
Merged

[Housekeeping] Enabling ignored tests #20129

merged 8 commits into from
Feb 2, 2024

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Jan 24, 2024

Description of Change

Enabling ignored tests:

  • Dashed Stroke Initializes Correctly (all variations)
  • Background Initializes Correctly (all variations)
  • Stroke Initializes Correctly (all variations)
  • CancelButtonColorInitializeCorrectly
  • StrokeShape Initializes Correctly (all variations)
  • BackgroundUpdatesCorrectly
  • DisconnectHandlerDoesntCrash
  • CursorPositionDoesntResetWhenNativeTextValueChanges

Issues Fixed

Related with #15530

@jsuarezruiz jsuarezruiz marked this pull request as ready for review January 29, 2024 14:43
@jsuarezruiz jsuarezruiz requested a review from a team as a code owner January 29, 2024 14:43
@@ -9,6 +8,28 @@ namespace Microsoft.Maui.DeviceTests
{
public partial class SliderHandlerTests
{
[Fact(DisplayName = "Thumb Color Initializes Correctly")]
public async Task ThumbColorInitializesCorrectly()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just use this code for all the platforms?

@mattleibow mattleibow merged commit 8ba0551 into main Feb 2, 2024
47 checks passed
@mattleibow mattleibow deleted the fix-15530 branch February 2, 2024 15:11
PureWeen pushed a commit that referenced this pull request Feb 8, 2024
* Background Initializes Correctly

* More changes

* More changes

* Fix ActivityIndicator background test

* Fixed DisconnectHandlerDoesntCrash on Windows

* Fixed Windows ThumbColorInitializesCorrectly

* Fixed CancelButtonColorInitializeCorrectly test on Windows

* Fixed CursorPositionDoesntResetWhenNativeTextValueChanges test on Windows
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants