Update SecureStorage.android.cs #20293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hey there @AnthonyNjuguna! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
samhouts
added
platform/android 🤖
area-essentials
|
Hey @AnthonyNjuguna thanks for the report and immediate fix too! Is there any way we could add a test for this so we're sure this is a good fix and more importantly: it won't regress again? |
Update SecureStorage_Tests.cs
AnthonyNjuguna
force-pushed
the
fix_for_android_secure_storage
branch
from
31af61f
to
1880c25
Compare
jsuarezruiz
approved these changes
Feb 2, 2024
|
Might also fix the issue I reported her: #19983 (my issue contains an example repository) |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
PureWeen
requested changes
Feb 5, 2024
jsuarezruiz
requested review from
jsuarezruiz
and removed request for
jsuarezruiz
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
I think @Redth found something, so we probably need to see what he found. |
|
Superseded by #20445 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
On PlatformRemoveAll we reset the _prefs to null. So that the encrypted_prefs_key and encrypted_prefs_value are created again on next value insert so that GetAsync can decrypt said value
Reasons:
Issues Fixed
Fixes #19983
Issues with Android SecureStorage.GetAsync returning null