[iOS][tests] NativeAOT: Do not treat warnings as errors in integration tests #20471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebase |
github-actions
bot
force-pushed
the
naot-tests-disable-warn-as-error
branch
from
9e66f38
to
b993677
Compare
|
/rebase |
github-actions
bot
force-pushed
the
naot-tests-disable-warn-as-error
branch
from
b993677
to
6531dba
Compare
rmarinho
approved these changes
Feb 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In .net8.0 NativeAOT compiler did not treat warnings as errors.
This got fixed in .net9.0 with: dotnet/runtime#96567
As there is a possibility that such fix will get backported, I am adding the escape mechanism to avoid our NativeAOT testing to start failing on the maui
mainbranch. Set properties should not change the behaviour of the test.Additionally, we have encountered exactly these failures when working on maui
net9.0branch because we started pulling in the mentioned fix:/cc: @simonrozsival @rmarinho