[iOS] NullReferenceException for Span GridItemsLayout fix #20492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hey there @kubaflo! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
This was referenced Feb 10, 2024
jsuarezruiz
added
area-layout
jsuarezruiz
approved these changes
Feb 12, 2024
|
/azp run MAUI-UITests-public |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @kubaflo can you explain how this fixes the issue ? Why is PropertyChanged firing before CollectionView be set? Maybe we need to fix why that event is firing ? |
@rmarinho Hi, I'm not quite sure, but it is related to binding to the page, because when using a constant value for the span instead of using the binding the PropertyChanged doesn't fire |
rmarinho
approved these changes
Feb 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added a null check
Issues Fixed
Fixes #19803
Fixes #18828
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-02-10.at.14.36.10.mp4