Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Adjust Keyboard Scrolling for Sticky Headers and Fix Bottom Content Inset #20562

Merged
merged 4 commits into from
Feb 15, 2024

Conversation

tj-devel709
Copy link
Member

Description of Change

This PR fixes two different issues regarding the iOS Keyboard Scrolling.

  1. If there is a "Sticky Header" or some other view above the scrollview, sometimes, the content would not take that in account and scroll the entry behind this header. The fix for this includes calculating the size of the scrollview and compare that to the standard boundaries of the navbar and status bar on the top, and the keyboard on the bottom.
Before After
StickyHeader_Before.mov
iOSStickyScrolling.mov
  1. When scrolling occurs on an entry or editor, we are not able to scroll to the bottom of the scrollview when the keyboard is still open. The fix for this one was changing the previous calculation on the content inset bottom to the size of the keyboard. Sometimes, simpler is better :)
Before After
BottomContentInset_Before.mov
iOSBottomInsets_After.mov

Issues Fixed

Fixes #19956
Fixes #20200

@tj-devel709 tj-devel709 added platform/iOS 🍎 legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor area-controls-entry Entry area-keyboard Keyboard, soft keyboard labels Feb 13, 2024
@tj-devel709 tj-devel709 requested a review from a team as a code owner February 13, 2024 22:35
@PureWeen PureWeen merged commit ee32869 into main Feb 15, 2024
41 of 49 checks passed
@PureWeen PureWeen deleted the dev/TJ/StickyHeaderScroll branch February 15, 2024 16:24
@mattleibow
Copy link
Member

This PR only touches iOS. The failing Windows and Android testa re currently being fixed in separate PRs.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2024
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants