-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[XC] Allow generic types in x:DataType and x:Type #20625
Merged
rmarinho
merged 5 commits into
dotnet:main
from
simonrozsival:xdatatype-and-xtype-allow-generic-types
Feb 16, 2024
Merged
[XC] Allow generic types in x:DataType and x:Type #20625
rmarinho
merged 5 commits into
dotnet:main
from
simonrozsival:xdatatype-and-xtype-allow-generic-types
Feb 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonrozsival
force-pushed
the
xdatatype-and-xtype-allow-generic-types
branch
from
February 15, 2024 20:22
32778a6
to
d627b7d
Compare
@StephaneDelcroix please take another look |
StephaneDelcroix
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good when green
rmarinho
approved these changes
Feb 16, 2024
pictos
pushed a commit
to pictos/maui
that referenced
this pull request
Feb 20, 2024
* Add parser for single type expression * Allow generic types in x:DataType * Allow generic types in x:Type * Add test * Improve test
rmarinho
pushed a commit
that referenced
this pull request
Feb 22, 2024
* Add parser for single type expression * Allow generic types in x:DataType * Allow generic types in x:Type * Add test * Improve test
rmarinho
pushed a commit
that referenced
this pull request
Feb 27, 2024
* Add parser for single type expression * Allow generic types in x:DataType * Allow generic types in x:Type * Add test * Improve test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
x:DataType
x:Type
(compiled and parsed at runtime)Issues Fixed
Fixes #20616