Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XC] Allow generic types in x:DataType and x:Type #20625

Merged

Conversation

simonrozsival
Copy link
Member

Description of Change

  • Adds support for generic types in x:DataType
  • Adds support for generic types in x:Type (compiled and parsed at runtime)

Issues Fixed

Fixes #20616

@simonrozsival simonrozsival force-pushed the xdatatype-and-xtype-allow-generic-types branch from 32778a6 to d627b7d Compare February 15, 2024 20:22
@simonrozsival
Copy link
Member Author

@StephaneDelcroix please take another look

Copy link
Contributor

@StephaneDelcroix StephaneDelcroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good when green

@rmarinho rmarinho merged commit 76e9f74 into dotnet:main Feb 16, 2024
39 of 47 checks passed
pictos pushed a commit to pictos/maui that referenced this pull request Feb 20, 2024
* Add parser for single type expression

* Allow generic types in x:DataType

* Allow generic types in x:Type

* Add test

* Improve test
rmarinho pushed a commit that referenced this pull request Feb 22, 2024
* Add parser for single type expression

* Allow generic types in x:DataType

* Allow generic types in x:Type

* Add test

* Improve test
rmarinho pushed a commit that referenced this pull request Feb 27, 2024
* Add parser for single type expression

* Allow generic types in x:DataType

* Allow generic types in x:Type

* Add test

* Improve test
@github-actions github-actions bot locked and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support compiled bindings for generic ViewModels
4 participants