[C] Propagate Resource changes to Background #20637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
added
area-xaml
StephaneDelcroix
force-pushed
the
fix_18545
branch
from
31507d3
to
7be26aa
Compare
StephaneDelcroix
changed the title
jsuarezruiz
reviewed
Feb 20, 2024
| @@ -109,6 +109,9 @@ void NotifyStrokeChanges() | |||
| _strokeChanged ??= (sender, e) => OnPropertyChanged(nameof(Stroke)); | |||
| _strokeProxy ??= new(); | |||
| _strokeProxy.Subscribe(stroke, _strokeChanged); | |||
|
|
|||
| OnParentResourcesChanged(this.GetMergedResources()); | |||
There was a problem hiding this comment.
Could we include a XAML Test covering these changes?
|
Hi there, is there a chance to make a nightly build soon? thank you |
jsuarezruiz
approved these changes
Feb 29, 2024
rmarinho
approved these changes
Feb 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
[C] Propagate Resource changes to VE.Background. Do that also for VE.Shadow, Border.Stroke, Shape.Fill and Stroke
Issues Fixed