[Android Connectivity] Set app package on Intent used to invoke context receiver for network callback #20651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattleibow
approved these changes
Feb 16, 2024
|
/rebase |
We are the only ones invoking these, so there's no need to export. The export made things 'work' on android 14 because of changes to that api level, but that wasn't the most correct fix.
With changes in android 14, we need to scope the connectivity intent we use to trigger our own internal broadcast receiver to the current app package (which we get from the application context).
github-actions
bot
force-pushed
the
dev/redth/broadcast-receiver-context
branch
from
0400a8f
to
94d42d2
Compare
|
Failing tests unrelated |
rmarinho
pushed a commit
that referenced
this pull request
Feb 22, 2024
…xt receiver for network callback (#20651) * No need to export app specific broadcast receivers We are the only ones invoking these, so there's no need to export. The export made things 'work' on android 14 because of changes to that api level, but that wasn't the most correct fix. * Set package on connectivity intent With changes in android 14, we need to scope the connectivity intent we use to trigger our own internal broadcast receiver to the current app package (which we get from the application context).
rmarinho
pushed a commit
that referenced
this pull request
Feb 27, 2024
…xt receiver for network callback (#20651) * No need to export app specific broadcast receivers We are the only ones invoking these, so there's no need to export. The export made things 'work' on android 14 because of changes to that api level, but that wasn't the most correct fix. * Set package on connectivity intent With changes in android 14, we need to scope the connectivity intent we use to trigger our own internal broadcast receiver to the current app package (which we get from the application context).
|
Just to say that ConnectivityChanged on android 14 on Maui 8.0.10 does not fire when you toggle on/off wifi or airplane mode |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Android 14.0 brings in more changes for scoping invocations of broadcast receivers. This changes to no longer export the 'internal' broadcast receiver we use for Essentials Connectivity API's (since we're the only ones expected to send broadcasts to it) and instead sets the package name of intent we broadcast to comply with OS changes and make this broadcast continue to work.
Issues Fixed
Better fix for #17861