Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup Android App With More Accurate settings #20672

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Setup Android App With More Accurate settings #20672

merged 4 commits into from
Feb 21, 2024

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Feb 18, 2024 •
edited
Loading

Description of Change

  • Rework the android appium app to correctly setup package ids
  • Rework reset to use terminate/launch which appears to be more reliable on Android

jsuarezruiz
jsuarezruiz previously approved these changes Feb 19, 2024
View reviewed changes
@PureWeen PureWeen marked this pull request as ready for review February 20, 2024 22:35
@PureWeen PureWeen requested a review from a team as a code owner February 20, 2024 22:35
@jsuarezruiz
Copy link
Contributor

LGTM! Waiting for build results.

@PureWeen
Copy link
Member Author

Failing tests are unrelated

@PureWeen PureWeen merged commit 8d517af into main Feb 21, 2024
43 of 47 checks passed
@PureWeen PureWeen deleted the fix_android_appium branch February 21, 2024 17:47
rmarinho pushed a commit that referenced this pull request Feb 22, 2024
@PureWeen @rmarinho
Setup Android App With More Accurate settings (#20672)
b261277 
* Setup Android App With More Accurate settings

* - fix iOS reset

* - fix windows

* Update HelperExtensions.cs
rmarinho pushed a commit that referenced this pull request Feb 27, 2024
@PureWeen @rmarinho
Setup Android App With More Accurate settings (#20672)
502d4cc 
* Setup Android App With More Accurate settings

* - fix iOS reset

* - fix windows

* Update HelperExtensions.cs
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

@jfversluis jfversluis Awaiting requested review from jfversluis

@rmarinho rmarinho Awaiting requested review from rmarinho

Assignees
No one assigned
Labels
area-testing Unit tests, device tests fixed-in-8.0.10 fixed-in-9.0.0-preview.2.10247 fixed-in-9.0.0-preview.2.10293 t/housekeeping ♻︎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PureWeen @jsuarezruiz @samhouts